release-notes-generator: conventional-changelog-conventionalcommits v8.0.0 breaks semantic release
It looks like v8.0.0 of conventional-changelog-conventionalcommits was released about an hour ago. This causes the semantic-release “generateNotes” step of plugin “@semantic-release/release-notes-generator” to fail:
$ npm --version
10.5.0
$ semantic-release --version
23.0.8
$ semantic-release
[11:48:10 PM] [semantic-release] › ℹ Running semantic-release version 23.0.8
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "verifyConditions" from "@semantic-release/changelog"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "verifyConditions" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "verifyConditions" from "@semantic-release/git"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "verifyConditions" from "@semantic-release/gitlab"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "analyzeCommits" from "@semantic-release/commit-analyzer"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "analyzeCommits" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "verifyRelease" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "generateNotes" from "@semantic-release/release-notes-generator"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "generateNotes" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "prepare" from "@semantic-release/changelog"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "prepare" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "prepare" from "@semantic-release/git"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "publish" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "publish" from "@semantic-release/gitlab"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "addChannel" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "success" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "success" from "@semantic-release/gitlab"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "fail" from "@semantic-release/exec"
[11:48:11 PM] [semantic-release] › ✔ Loaded plugin "fail" from "@semantic-release/gitlab"
[11:48:15 PM] [semantic-release] › ✔ Run automated release from branch master on repository [https://gitlab-ci-token:[secure]@gitlab.com/foo/bar.git](https://gitlab-ci-token:%5Bsecure%5D@gitlab.com/foo/bar.git)
[11:48:15 PM] [semantic-release] › ✔ Allowed to push to the Git repository
[11:48:15 PM] [semantic-release] › ℹ Start step "verifyConditions" of plugin "@semantic-release/changelog"
[11:48:15 PM] [semantic-release] › ✔ Completed step "verifyConditions" of plugin "@semantic-release/changelog"
[11:48:15 PM] [semantic-release] › ℹ Start step "verifyConditions" of plugin "@semantic-release/exec"
[11:48:15 PM] [semantic-release] › ✔ Completed step "verifyConditions" of plugin "@semantic-release/exec"
[11:48:15 PM] [semantic-release] › ℹ Start step "verifyConditions" of plugin "@semantic-release/git"
[11:48:15 PM] [semantic-release] › ✔ Completed step "verifyConditions" of plugin "@semantic-release/git"
[11:48:15 PM] [semantic-release] › ℹ Start step "verifyConditions" of plugin "@semantic-release/gitlab"
[11:48:15 PM] [semantic-release] [@semantic-release/gitlab] › ℹ Verify GitLab authentication (https://gitlab.com/api/v4)
[11:48:15 PM] [semantic-release] › ✔ Completed step "verifyConditions" of plugin "@semantic-release/gitlab"
[11:48:15 PM] [semantic-release] › ℹ Found git tag v1.4.0 associated with version 1.4.0 on branch master
[11:48:15 PM] [semantic-release] › ℹ Found 1 commits since last release
[11:48:15 PM] [semantic-release] › ℹ Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:48:15 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ Analyzing commit: fix: make the esg rule name not clash with other domains
This was not applying properly because the rule has the same name as a
rule created by a different AWS account on the same bus.
[11:48:15 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ The release type for the commit is patch
[11:48:15 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ Analysis of 1 commits complete: patch release
[11:48:15 PM] [semantic-release] › ✔ Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[11:48:15 PM] [semantic-release] › ℹ Start step "analyzeCommits" of plugin "@semantic-release/exec"
[11:48:15 PM] [semantic-release] › ✔ Completed step "analyzeCommits" of plugin "@semantic-release/exec"
[11:48:15 PM] [semantic-release] › ℹ The next release version is 1.4.1
[11:48:15 PM] [semantic-release] › ℹ Start step "verifyRelease" of plugin "@semantic-release/exec"
[11:48:15 PM] [semantic-release] › ✔ Completed step "verifyRelease" of plugin "@semantic-release/exec"
[11:48:15 PM] [semantic-release] › ℹ Start step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[11:48:15 PM] [semantic-release] › ✘ Failed step "generateNotes" of plugin "@semantic-release/release-notes-generator"
[11:48:15 PM] [semantic-release] › ✘ An error occurred while running semantic-release: RangeError: Invalid time value
at committerDate (/usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/index.js:80:30)
at /usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/lib/util.js:202:17
at Array.forEach (<anonymous>)
at processCommit (/usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/lib/util.js:198:31)
at /usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/index.js:123:32 {
pluginName: '@semantic-release/release-notes-generator'
}
RangeError: Invalid time value
at committerDate (/usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/index.js:80:30)
at /usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/lib/util.js:202:17
at Array.forEach (<anonymous>)
at processCommit (/usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/lib/util.js:198:31)
at /usr/local/lib/node_modules/semantic-release/node_modules/conventional-changelog-writer/index.js:123:32 {
pluginName: '@semantic-release/release-notes-generator'
}
Reverting conventional-changelog-conventionalcommits back to the v7.x.x series makes this release run fine again.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 52
- Comments: 28 (9 by maintainers)
Commits related to this issue
- ci: fix deployments Seems like there is a bug with semantic-release plugins conflicting with latest major conventional commits. Reverting as issue suggests: https://github.com/semantic-release/releas... — committed to levibostian/Wendy-iOS by levibostian 3 years ago
- ci: fix deployments Seems like there is a bug with semantic-release plugins conflicting with latest major conventional commits. Reverting as issue suggests: https://github.com/semantic-release/releas... — committed to levibostian/Wendy-iOS by levibostian 3 years ago
- chore(deps-dev): 🔧 downgrade conventional-changelog-conventionalcommits see https://github.com/semantic-release/release-notes-generator/issues/633 — committed to iwpnd/rip-ts by iwpnd 3 years ago
- chore(deps-dev): 🔧 downgrade conventional-changelog-conventionalcommits see https://github.com/semantic-release/release-notes-generator/issues/633 — committed to iwpnd/rip-ts by iwpnd 3 years ago
- chore(deps-dev): 🔧 downgrade conventional-changelog-conventionalcommits see https://github.com/semantic-release/release-notes-generator/issues/633 — committed to iwpnd/tile38-ts by iwpnd 3 years ago
- fix(semantic-release): pin conventionalcommits https://github.com/semantic-release/release-notes-generator/issues/633#issuecomment-2094571737 — committed to guidojw/actions by guidojw 3 years ago
- fix(semantic-release): pin conventionalcommits (#48) https://github.com/semantic-release/release-notes-generator/issues/633#issuecomment-2094571737 — committed to guidojw/actions by guidojw 3 years ago
- fix: Revert "chore(deps-dev): bump conventional-changelog-conventionalcommits (#164)" (#167) https://github.com/semantic-release/release-notes-generator/issues/633 — committed to appium/io.appium.settings by mykola-mokhnach 3 years ago
- fix: Revert "chore(deps): update dependency conventional-changelog-conventionalcom…" (#20084) https://github.com/semantic-release/release-notes-generator/issues/633 — committed to appium/appium by mykola-mokhnach 3 years ago
- ci: Pin conventional-changelog-conventionalcommits to v7.0.2 The latest version has a conflict with the latest version of semantic-release https://github.com/semantic-release/release-notes-generator/... — committed to getappmap/appmap-intellij-plugin by dustinbyrne 3 years ago
- fix(ci): pin conventional-changelog-conventionalcommits to 7.0.2 The latest major version (`8.0.0`) containing breaking changes, which are not yet included in release-notes-generator. Therefore, pin ... — committed to MediaMarktSaturn/technolinator by beiertu-mms 3 years ago
- fix(ci): pin conventional-changelog-conventionalcommits to 7.0.2 (#457) The latest major version (`8.0.0`) containing breaking changes, which are not yet included in release-notes-generator. Theref... — committed to MediaMarktSaturn/technolinator by beiertu-mms 3 years ago
- build(npm): set conventional-changelog-conventionalcommits to 7.0.2 see this comment for more details: https://github.com/semantic-release/release-notes-generator/issues/633#issuecomment-2100094407 — committed to mlg87/pr-reviewer-slack-notify-action by mlg87 3 years ago
- Release 8.0.0 - May 10, 2024, 10:40 PM MDT [skip ci] ## [8.0.0](https://github.com/mlg87/pr-reviewer-slack-notify-action/compare/v7.8.1...v8.0.0) (2024-05-11) ### ⚠ BREAKING CHANGES * **npm:** node... — committed to mlg87/pr-reviewer-slack-notify-action by semantic-release-bot 3 years ago
- ci: pin conventional-changelog-conventionalcommits version Relates: semantic-release/release-notes-generator#633 — committed to geokrety/geokrety-gha-workflows by kumy 3 years ago
- fix: pin conventional-changelog-conventionalcommits to v7 https://github.com/semantic-release/release-notes-generator/issues/633 — committed to mrtnvh/mrtnvh by mrtnvh 3 years ago
- fix: Conventional commit version See https://github.com/semantic-release/release-notes-generator/issues/633#issuecomment-2100094407 — committed to lenra-io/github-actions by taorepoara 3 years ago
- fix: downgrade conventional-changelog-conventionalcommits See https://github.com/semantic-release/release-notes-generator/issues/633 — committed to open-turo/semantic-release-config by tagoro9 3 years ago
- fix: downgrade conventional-changelog-conventionalcommits See https://github.com/semantic-release/release-notes-generator/issues/633 — committed to open-turo/semantic-release-config by tagoro9 3 years ago
- fix: downgrade conventional-changelog-conventionalcommits See https://github.com/semantic-release/release-notes-generator/issues/633 — committed to open-turo/semantic-release-config by tagoro9 3 years ago
Thank you @sherbakovdev for contributing to getting this out the door and to @ryancausey and @imliuruiqi for testing out the fix and confirming that it solved the problem in your projects 🎉
We have the same issue… Decided to downgrade for only package which is causing troubles to
conventional-changelog-conventionalcommits@7.0.2https://github.com/semantic-release/semantic-release/releases/tag/v24.0.0-beta.2 should resolve this problem and enable use of the latest conventional-changelog packages.
it would be appreciated if folks following this issue that have experienced problems with the new major versions of the conventional-changelog plugins and let us know if this version resolves the problem for you
I agree that is what people should do. However, the problem I found is that is currently hard to test if a major version bump will cause something to fail as we have semantic-release only running on our main branch. Implementing https://github.com/semantic-release/semantic-release/issues/3278 would allow us to at least run with dry-run in a branch where we upgrade versions and see if anything breaks
For folks landing here for various breakages related to updating conventional-commits packages before semantic-release is updated to handle the breaking changes, I’m trying to consolidate the conversation in this thread.
Until I get more organized about that, please see my suggestions in https://github.com/semantic-release/semantic-release/issues/3292#issuecomment-2099434430
I’ve tested with this and it resolved my issue.
@travi yeah that makes sense. If we need to customize the preset though, we have to install it, and then it’s easy to install the wrong version… so should we make this package check the version of the preset at runtime, and at least print a warning? I would almost suggest we put the compatible version in
optionalDependencies, but package managers, confoundingly, install optional dependencies by default. So the best I can think to do is a runtime check. I’d be happy to make a PR.I had the error even with
conventional-changelog-conventionalcommitsv7.x.x; it seems like it was being caused because the preset I was using with@semantic-release/commit-analyzerdidn’t match the preset I was using with@semantic-release/release-notes-generator. When I made them match, the error went away with v8.0.0.FYI, tried on self-hosted gitlab with python project and it works as expected. 🎉
configuration of
semantic-release:@ashvardanian the new beta of semantic-release is intended to work with the latest majors of conventional-changelog presets. As mentioned in the release notes, that means older version will no longer work. For the eslint preset, it looks like v6.0.0 is the latest version, but you’re project is still configured to use v3.
the conventional-changelog packages released new major versions. that means they include breaking changes. since they were just released, no work has been done to make adjustments to account for the changes in semantic-release.
if someone would be willing to investigate what changes would be needed, that could help us adjust for these changes sooner