Semantic-UI: [build] gulp build command not working

gulp build can’t complete the ‘build-assets’ phase due to the following error:

GulpUglifyError: unable to minify JavaScript
Caused by: DefaultsError: `preserveComments` is not a supported option
semantic/tasks/config/tasks.js:96
          if(error.filename.match(/theme.less/)) {
                           ^
TypeError: Cannot read property 'match' of undefined

And is NOT fixed by commenting the following lines:

./tasks/config/tasks.js:148:      preserveComments : 'some'
./tasks/config/tasks.js:162:      preserveComments : false

Steps to reproduce it:

npm install semantic-ui --save
cd semantic/
gulp build

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 41 (8 by maintainers)

Commits related to this issue

#5391 - Fixes issue with deprecated uglify setting in build tools — committed to Semantic-Org/Semantic-UI by jlukic 7 years ago
Really fix #5391 — committed to Semantic-Org/Semantic-UI by jlukic 7 years ago
Fix site's dependency on semantic-ui to 2.2.10 because there is an issue with 2.2.11 (https://github.com/Semantic-Org/Semantic-UI/issues/5391) — committed to geb/geb by erdi 7 years ago

Most upvoted comments

Hi, I found that Uglify plugin changed its options and now preserveComments is obsolete:

https://github.com/gruntjs/grunt-contrib-uglify#deprecated-options-from-2x

Option           | Replacement
preserveComments | output.comments

So, just replacing in these 2 lines in semantic/tasks/config/tasks.js:

./tasks/config/tasks.js:148:      preserveComments : 'some'
./tasks/config/tasks.js:162:      preserveComments : false

with:

output: {
    comments: 'some'
}

output: {
    comments: false
}

worked for me.

+13

sergiomar73 on Aug 2, 2017

I think I found the problem. This issue … https://github.com/terinjokes/gulp-uglify/issues/265 … and the latest gulp-uglify release notes reveal that release v3.0.0 of gulp-uglify REMOVED the custom option preserveComments 😃

+11

designosis on Jul 11, 2017

I’ll fix the dependencies so that we dont use this version of uglify. Sorry about this guys.

jlukic on Jul 15, 2017

@cluxter dont worry, I’m releasing this later tonight. Continuing to jam on issues. Manual fix above should work in interim.

jlukic on Aug 6, 2017

Will get fix in over weekend. Thanks for patience.

jlukic on Jul 28, 2017

And out 2.2.13

jlukic on Aug 7, 2017

Yep, can confirm the issue. Commenting out L148 & L162 (temporarily) solves it.

Tried with older version of Node / npm & latest version too. It’s not camelCase related or node version related

vinayakkulkarni on Jul 12, 2017

A weekend late but pushing this now.

jlukic on Aug 6, 2017

@tarkwyn Can you make a pull request to fix this?

j-f1 on Jun 22, 2017

Hi, @jlukic I have installed de last updates (2.2.13) of semantic and tried build the project. The fix worked succefully.

Thanks a lot.

zehmigueljr on Aug 7, 2017