php-code-coverage: Executable code not shown as executed/executable

FYI I see xdebug 2.5.1 was released today and includes the patch for this issue https://xdebug.org/updates.php#x_2_5_1

It does! Please add an xdebug ticket with the relevant info!

https://github.com/xdebug/xdebug/commit/80e9144b47f1847eb80f33f89e6f9c07eb4d8c7c

So I guess this can be closed now.

Ok, after some digging I have been able to build a small script that reproduces the problem in XDebug and it is completely independent of the phpunit code. Here it is:

// test.php
xdebug_start_code_coverage(XDEBUG_CC_UNUSED | XDEBUG_CC_DEAD_CODE);

include 'TestClass2.php';
include 'TestClass.php';
$Test1 = new TestClass();

var_dump(xdebug_get_code_coverage());

// TestClass.php
class TestClass extends TestClass2
{
    public function test()
    {
        $a = 5*5;
        $b = $a*2;
        return $b;
    }
}

// TestClass2.php
class TestClass2
{
    public function test()
    {
        $a = 5*5;
        $b = $a*2;
        return $b;
    }
}

As you can see TestClass extends TestClass2. When I remove extends TestClass2, the bug does not occur. Also, when I put the line include 'TestClass2.php' directly in TestClass.php, the bug also does not occur. So it has to do with the fact that the class is included in a top level file, but extended from in another file. The bug does occur in PHP7, but not in PHP5.

This shows an XDebug related issue, therefore I will start an issue thread on their bugtracker.

Fast work there! Thank you so much, I’ll compile and try out the master branch now. Kudos to JoepRoebroek for figuring the cause. Happy New Year!

Thanks @lordelph 👍

Thanks for investigating!

Ok, I investigated the code some more and concluded that my initial addition should already be done by the function initializeFilesThatAreSeenTheFirstTime. However this function is flawed when it is called multiple times and is presented with the same file, but where each file contains different lines in its array.

Therefore, the following fix also works:

 foreach ($data as $file => $lines) {
-    if ($this->filter->isFile($file) && !isset($this->data[$file])) {
+    if ($this->filter->isFile($file)) {
+        if(!isset($this->data[$file])) {
               $this->data[$file] = [];
+       }
        foreach ($lines as $k => $v) {
+           if (!isset($this->data[$file][$k])) {
                $this->data[$file][$k] = $v == -2 ? null : [];
+           }
        }
    }
}

Let me know what you think. I tried phpunit with #!/usr/bin/env php5 aswell, to see what the difference is. And with PHP5, the inital call to xdebug_get_code_coverage returns an array with all lines containing executable code, whereas in PHP7 this does not happen. Therefore, I think the above fix is sufficient.