NeuralAmpModelerPlugin: std::filesystem::path is not supported in macOS<10.15

Use of std::filesystem::path is preventing support for macOS versions before 10.15.

Tags: Mojave, High Sierra, 10.14, 10.13

About this issue

  • Original URL
  • State: open
  • Created 2 years ago
  • Comments: 15 (10 by maintainers)

Most upvoted comments

I think it would be better to just pass paths as strings, rather than add another dependency with https://github.com/gulrak/filesystem.

From looking at the code, it isn’t doing much specific to std::filesystem::path beyond some file existence checks.

One idea would be to just assimilate gulrak’s filesystem to this repo without a submodule as it work well as for now… 😛 but I don’t know what harm there’d be to add a submodule as they’re already used extensively in this one!

On a side-note, iPlug2 removed the only lines that made it C++17 only, which is really cool! 😃 ( https://github.com/iPlug2/iPlug2/commit/bc5aae0998c1cabc060a144adde56d7080d1317c )

I think it would be better to just pass paths as strings, rather than add another dependency with https://github.com/gulrak/filesystem.

From looking at the code, it isn’t doing much specific to std::filesystem::path beyond some file existence checks.

Looking forward to a fix to be able to use in Mojave thank you

https://github.com/masqutti/NeuralAmpModelerPlugin/commit/e3fa057f1f110b8d92dabd70d00f04a3415eed1c

Here’s info how I did it, it’s not a big change but I am unfortunately too occupied at the moment to do pull requests myself. It requires the https://github.com/gulrak/filesystem to exist and subfolder “Include” added as to header search paths to allow building. Also iPlug2 needs two small changes in couple of places (you will notice when you try to build) which are about Structured bindings (not possible with C++14) and very easy to fix, probably ideal to have iPlug2 issue / pull request about them since compiler only complained about 2 lines.

I’ve confirmed this to work on Windows 10 but not yet on MacOS.