seastar: unit.tls sometimes fails on short read
.../unit/tls_test.cc(89): error: in "test_x509_client_with_builder_system_trust_multiple": check buf.size() > 8 has failed
Failing assertion:
auto f = in.read();
return f.then([](temporary_buffer<char> buf) {
// std::cout << buf.get() << std::endl;
// Avoid passing a nullptr as an argument of strncmp().
// If the temporary_buffer is empty (e.g. due to the underlying TCP connection
// being reset) passing the buf.get() (which would be a nullptr) to strncmp()
// causes a runtime error which masks the actual issue.
if (buf) {
BOOST_CHECK(strncmp(buf.get(), "HTTP/", 5) == 0);
}
This one >>> BOOST_CHECK(buf.size() > 8);
});
examples: https://app.circleci.com/pipelines/github/scylladb/seastar/1306/workflows/34276448-c252-4b70-979c-e200e290a024/jobs/2577 https://app.circleci.com/pipelines/github/scylladb/seastar/1309/workflows/9be37ca0-183b-4225-bbdf-a0095be22261/jobs/2619
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 19 (19 by maintainers)
Commits related to this issue
- tls_test: Make google https connect routine loop buffer reads Refs #1127 Just in case we actually read a _very_ short buffer (< 8). Also make more explicit noise iff reading fails (early EOF) — committed to elcallio/seastar by deleted user 2 years ago
- tls_test: Make google https connect routine loop buffer reads Refs #1127 Just in case we actually read a _very_ short buffer (< 8). Also make more explicit noise iff reading fails (early EOF) Close... — committed to scylladb/seastar by deleted user 2 years ago
- tls_test: Remove dns bottle neck + improve read loop in google connect test Refs #1127 (does _NOT_ fix anything really) Remove DNS query race/bottleneck from multiple connect test (only happens if r... — committed to elcallio/seastar by deleted user 2 years ago
- tls_test: Remove dns bottle neck + improve read loop in google connect test Refs #1127 (does _NOT_ fix anything really) Remove DNS query race/bottleneck from multiple connect test (only happens if r... — committed to scylladb/seastar by deleted user 2 years ago
- tls_test: Remove dns bottle neck + improve read loop in google connect test Refs #1127 (does _NOT_ fix anything really) Remove DNS query race/bottleneck from multiple connect test (only happens if r... — committed to howardlau1999/seastar by deleted user 2 years ago
- tls_test: Fix spurious fail in test_x509_client_with_builder_system_trust_multiple (et al) Fixes #1127 google servers have a (pretty short) timeout between connect and expected first write. If we ar... — committed to elcallio/seastar by deleted user 2 years ago
- tls_test: Fix spurious fail in test_x509_client_with_builder_system_trust_multiple (et al) Fixes #1127 google servers have a (pretty short) timeout between connect and expected first write. If we ar... — committed to pgellert/seastar by deleted user 2 years ago
Why can’t we make it in the thread-pool’s thread? Even if there are many verifications, let them “stall” in the context of that thread, not reactor.