scully: cli: dist/static does not include assets if Angular project is output to dist/
π Bug report
Description
In dist/static, I have the following
- index.html
- assets
- scully-routes.json
My webmanifest.manifest
, favicon.ico
, sitemap.xml
, robots.txt
, etc arenβt available on my static site. It seems like all of this stuff is configured in the angular.json
and part of my build in dist/
, so it seems like Scully should copy that over for the static site? Or is there some other step or approach that Iβm missing?
π¬ Minimal Reproduction
- Generate a new app with the CLI
- Follow the Scully docs
- Check to see if your
favicon.ico
loads on your static site and that itβs indist/static/favicon.ico
π»Your Environment
Angular Version:
Angular CLI: 9.0.0-rc.6
Node: 12.13.0
OS: darwin x64
Angular: 9.0.0-rc.6
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker
Ivy Workspace: Yes
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.900.0-rc.6
@angular-devkit/build-angular 0.900.0-rc.6
@angular-devkit/build-optimizer 0.900.0-rc.6
@angular-devkit/build-webpack 0.900.0-rc.6
@angular-devkit/core 9.0.0-rc.6
@angular-devkit/schematics 9.0.0-rc.6
@angular/cdk 9.0.0-rc.5
@angular/fire 5.2.3
@angular/material 9.0.0-rc.5
@ngtools/webpack 9.0.0-rc.6
@schematics/angular 9.0.0-rc.6
@schematics/update 0.900.0-rc.6
rxjs 6.5.3
typescript 3.6.4
webpack 4.41.2
Scully Version:
"@scullyio/init": "0.0.8",
"@scullyio/ng-lib": "latest",
"@scullyio/scully": "latest",
π₯ Exception or Error
GET http://localhost:5000/firebase-performance-es2015.js net::ERR_ABORTED 404 (Not Found)
(index):2790 GET http://localhost:5000/runtime-es2015.js net::ERR_ABORTED 404 (Not Found)
4(index):2790 GET http://localhost:5000/polyfills-es2015.js net::ERR_ABORTED 404 (Not Found)
16(index):2762 GET http://localhost:5000/assets/DevIntentLogo.png 404 (Not Found)
(index):2790 GET http://localhost:5000/assets/material-design-icons/MaterialIcons-Regular.woff2 net::ERR_ABORTED 404 (Not Found)
(index):2792 GET http://localhost:5000/assets/material-design-icons/MaterialIcons-Regular.woff net::ERR_ABORTED 404 (Not Found)
(index):1 GET http://localhost:5000/assets/material-design-icons/MaterialIcons-Regular.ttf net::ERR_ABORTED 404 (Not Found)
manifest.webmanifest:1 GET http://localhost:5000/manifest.webmanifest 404 (Not Found)
manifest.webmanifest:1 Manifest: Line: 1, column: 1, Syntax error.
favicon.ico:1 GET http://localhost:5000/favicon.ico 404 (Not Found)
favicon-32x32.png:1 GET http://localhost:5000/assets/favicon-32x32.png 404 (Not Found)
favicon-16x16.png:1 GET http://localhost:5000/assets/favicon-16x16.png 404 (Not Found)
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 17 (16 by maintainers)
Commits related to this issue
- test(checking out assets issue): this branch is meant to figure out how assets can be missing re #56 — committed to scullyio/scully by SanderElias 5 years ago
- improvement(cofig.ts): throw an error when `./dist` is used as outputpath in angular.json We will run into trouble when an user uses './dist` without subfolder. This PR does docuent that, and also ma... — committed to scullyio/scully by SanderElias 4 years ago
- improvement(cofig.ts): throw an error when `./dist` is used as outputpath in angular.json (#188) We will run into trouble when an user uses './dist` without subfolder. This PR does docuent that, and... — committed to scullyio/scully by SanderElias 4 years ago
OK, I changed my project to output to
dist/web
instead ofdist/
inangular.json
and I now get theπ new Angular build imported
and my assets are all properly copied.I also have the same issue and this workaround worked.
Yes, it is already doing that. But somehow itβs not always pulling in all assets, while it pull sin the rest of the app. Looking into that
Op vr 20 dec. 2019 om 17:02 schreef Michael Prentice < notifications@github.com>:
@Splaktar thanks for found the issue! β¦ @SanderElias can you check this?