salt: [BUG] 3003 pillar calls are twice as slow comparing to 3001.3

Description We’re testing an update from 3001.3 to 3003.0 and we noticed that any pillars call now takes roughly twice as long.

Note that we use pillarstack for pillars.

Steps to Reproduce the behavior

time salt-call pillar.ls

Expected behavior The call time should be roughly the same or expected performance regression should be documented.

Versions Report All minions and master are always on the same version in both examples.

salt --versions-report for 3003

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

Salt Version:
          Salt: 3003

Dependency Versions:
          cffi: 1.14.5
      cherrypy: Not Installed
      dateutil: Not Installed
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 2.11.3
       libgit2: Not Installed
      M2Crypto: 0.37.1
          Mako: Not Installed
       msgpack: 1.0.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     pycparser: 2.20
      pycrypto: Not Installed
  pycryptodome: 3.10.1
        pygit2: Not Installed
        Python: 3.6.8 (default, Nov 16 2020, 16:55:22)
  python-gnupg: Not Installed
        PyYAML: 5.4.1
         PyZMQ: 19.0.2
         smmap: Not Installed
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.2

System Versions:
          dist: centos 7 Core
        locale: UTF-8
       machine: x86_64
       release: 3.10.0-1062.18.1.el7.x86_64
        system: Linux
       version: CentOS Linux 7 Core

salt --versions-report for 3001.3

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

Salt Version:
           Salt: 3001.3

Dependency Versions:
           cffi: 1.14.5
       cherrypy: Not Installed
       dateutil: Not Installed
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
         Jinja2: 2.10.3
        libgit2: Not Installed
       M2Crypto: 0.37.1
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 1.0.0
   mysql-python: Not Installed
      pycparser: 2.20
       pycrypto: 2.6.1
   pycryptodome: 3.9.7
         pygit2: Not Installed
         Python: 3.6.8 (default, Aug  7 2019, 17:28:10)
   python-gnupg: 0.4.5
         PyYAML: 5.3.1
          PyZMQ: 19.0.2
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.3.2

System Versions:
           dist: centos 7 Core
         locale: UTF-8
        machine: x86_64
        release: 3.10.0-1127.10.1.el7.x86_64
         system: Linux
        version: CentOS Linux 7 Core

Additional context Trace logs for 3003: https://gist.github.com/Oloremo/55550d16d0be71466edfdf6432237f04

Trace logs for 3001.3: https://gist.github.com/Oloremo/24f76197f6a44c4937f8a0504f3ce1c5

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 2
Comments: 18 (18 by maintainers)

Most upvoted comments

@garethgreenaway

~45000 LoC in yaml 🙄

Oloremo on May 11, 2021