salt: [2017.7.7] salt-master with gitfs fails to start on centos7.5 with latest pygit2

Description of Issue/Question

salt-master with gitfs fails to start on centos7.5 with latest pygit2

Setup

CentOS 7.5 Salt-Master 2017.7.7 python-pygit2.x86_64 0:0.26.4-1.el7

Steps to Reproduce Issue

$ cat /etc/redhat-release
CentOS Linux release 7.5.1804 (Core)
$ rpm -qa | grep git2
libgit2-0.26.6-1.el7.x86_64
python-pygit2-0.26.4-1.el7.x86_64
$ cat /var/log/salt/master
2018-09-10 11:41:39,111 [salt.utils.gitfs :359 ][CRITICAL][27230] Exception caught while initializing gitfs remote 'git@mygitlab.example.com:user/repo.git': global name 'git' is not defined
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/utils/gitfs.py", line 353, in __init__
    self.new = self.init_remote()
  File "/usr/lib/python2.7/site-packages/salt/utils/gitfs.py", line 1474, in init_remote
    self.configure_refspecs()
  File "/usr/lib/python2.7/site-packages/salt/utils/gitfs.py", line 529, in configure_refspecs
    except (git.exc.GitCommandError, GitRemoteError) as exc:
NameError: global name 'git' is not defined
2018-09-10 11:41:39,112 [salt.master      :496 ][CRITICAL][27230] Failed to load gitfs
2018-09-10 11:41:39,112 [salt.master      :497 ][CRITICAL][27230] Master failed pre flight checks, exiting

Versions Report

Salt Version:
           Salt: 2017.7.7

Dependency Versions:
           cffi: 1.6.0
       cherrypy: Not Installed
       dateutil: 1.5
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.7.2
        libgit2: 0.26.3
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.1
   mysql-python: Not Installed
      pycparser: 2.14
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: 0.26.4
         Python: 2.7.5 (default, Aug  4 2017, 00:39:18)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.3.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4

System Versions:
           dist: centos 7.5.1804 Core
         locale: UTF-8
        machine: x86_64
        release: 3.10.0-693.5.2.el7.x86_64
         system: Linux
        version: CentOS Linux 7.5.1804 Core

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 18 (10 by maintainers)

Most upvoted comments

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

Unfortunately, you won’t get a response. Once they mark it as blocked/cannot reproduce they rarely come back to the issue. I think its fixed in 2018.