salt: [2017.7.0rc1] use_superseded and module.run changes from release notes do nothing?

Description of Issue/Question

Following the release notes here https://docs.saltstack.com/en/develop/topics/releases/2017.7.0.html#state-module-changes

I run into the following issue…

  1. add the following to the minion config
use_superseded:
  - module.run
  1. restart the minion
  2. update one of the states to the new format
  3. run state.sls my.state.here
local:
    Data failed to compile:
----------
    State 'run_something' in SLS 'my.state.here' is not formed as a list

I played tried a few different things based on the example

# super simplified example from notes
run_something:
  module.run:
    test.ping:
      - name: some name

# failed attempts to fix my code
#package::upgrade:
#  module.run:
#    pkg.upgrade:
#      - name: package::do_upgrade
#package::upgrade:
#  module.run:
#    pkg.upgrade
#package::upgrade:
#  module.run:
#    pkg.upgrade:

For now i have reverted to the old state file which works fine:

######
## common.package.upgrade
## -----------------------------------
######

## full update
package::refresh:
 module.run:
    - name: pkg.refresh_db

package::upgrade:
 module.run:
    - name: pkg.upgrade

This works with or without the following in the minion config

use_superseded:
  - module.run

Setup

See above

Steps to Reproduce Issue

See above

Versions Report

           Salt: 2017.7.0rc1

Dependency Versions:
           cffi: 1.9.1
       cherrypy: unknown
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: 2.0.0
      gitpython: 0.3.2 RC1
          ioflo: 1.6.7
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: 1.5.0
       M2Crypto: 0.22
           Mako: 1.0.6
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: 1.2.5
      pycparser: 2.17
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.12 (default, Jan 26 2017, 18:07:59)
   python-gnupg: 2.2.0
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: 0.6.7
          smmap: 0.9.0
        timelib: 0.2.4
        Tornado: 4.3
            ZMQ: 4.1.4

System Versions:
           dist:
         locale: UTF-8
        machine: i86pc
        release: 5.11
         system: SunOS
        version: Not Installed```

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 19 (15 by maintainers)

Most upvoted comments

Good Catch, that needs to be fixed.

It should be

fetch_out_of_band:
  module.run:
    - git.fetch:
      - cwd: /path/to/my/repo
      - user: myuser
      - opts: '--all'