media-controls: GNOME 48 support - Mpris.MediaSection is undefined
Describe the bug
The extension shows a TypeError: Mpris.MediaSection is undefined in the Extensions app (see the first screenshot) and starts working incorrectly (e.g. showing the controls like on the second screenshot or the Artist - Track name text being shown full width instead of scrolling)
To Reproduce Steps to reproduce the behavior:
- Install the extension from GNOME Extensions (same if installed from Github Releases).
- Enable the extension.
- See this error in the extension manager and see the media controls as if it was a web page with no style sheet.
Expected behavior Correct styling and no errors shown.
Screenshots
Environment:
- Distro: Debian GNU/Linux 13 (trixie)
- GNOME version: 48
- Extension version: 2.0.2 (as shown in GNOME Extensions app)
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 20 (17 by maintainers)
Commits related to this issue
- GNOME 48 - scrolling label fix #192 — committed to sakithb/media-controls by ChrisLauinger77 2 years ago
- GNOME 48 - scrolling label fix #192 (#193) — committed to stark81/media-controls by ChrisLauinger77 2 years ago
Here is the latest test version where scrolling label works again in GNOME 48
mediacontrols@cliffniff.github.com.zip
Submitted!
mediacontrols@cliffniff.github.com.shell-extension.zip
Applied those changes in this build.
I will do that today in the afternoon
I regret adding typescript and plan to convert everything back to javascript with a more simple build system. JSdocs should be enough for type checking.
We have no released version for gnome 48 (yet). But the changes are already in master branch. #185 #190
Here is a zip which works in GNOME 48
mediacontrols@cliffniff.github.com.zip