dav: Help debugging a calendar query error

Hi,

I’ve been working with HomeAssistant (Core 2020.12.1 installed on a recent Gentoo server) in connecting to a Baïkal calendar and have been tracing an odd issue. In debugging I’m seeing that the query is handled by sabre-io/dav and then passed to sabre-io/vobject, but I believe sabre-io/dav is the correct place to discuss this issue. See below for further details.

I’ve connected successfully to the test calendar using AgenDav and Moz Thunderbird, so everything appears to be working well with Baïkal (v0.7.2). When HomeAssistant attempts to connect to the server, it sends several successful request (PROPFINDs with 207 results), but eventually uses python’s caldav package (v0.6.1) to create the following calendar query to the Baïkal server.

<?xml version='1.0' encoding='utf-8'?>
<C:calendar-query xmlns:D="DAV" xmlns:C="urn:ietf:params:xml:ns:caldav" xmlns:I="http://apple.com/ns/ical/">
  <ns0:prop xmlns:ns0="DAV:">
    <C:calendar-data>
      <C:expand start="20210108T080000Z" end="20210115T080000Z"/>
    </C:calendar-data>
  </ns0:prop>
  <C:filter>
    <C:comp-filter name="VCALENDAR">
      <C:comp-filter name="VEVENT">
        <C:time-range start="20210108T080000Z" end="20210115T080000Z"/>
      </C:comp-filter>
    </C:comp-filter>
  </C:filter>
</C:calendar-query>

This query is received by the Baïkal instance running on apache (on the same host) and apache unfortunately returns a 500 error:

<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:sabredav-version>4.1.2</s:sabredav-version>
  <s:exception>Sabre\\VObject\\ParseException</s:exception>
  <s:message>This parser only supports VCARD and VCALENDAR files</s:message>
</d:error>

I put a print statement in saber/vobject’s MimeDir.php file at the above error output and a timezone string is output, so I changed the timezone setting on the Baïkal calendar being queried and that change was reflected in the debugging output. I put a stack trace into that point in the code (baikal/vendor/sabre/vobject/lib/Parser/MimeDir.php after the default in the switch statement) and got this:

I’m not a rfc4791 expert, just a guy trying to get a shared calendar resource setup on his home server for use in some home automation. If anyone can look over the calendar-query or the backtrace to ensure it’s valid or other acceptable caldav requests, please let me know.

Any suggestions on how to further debug this would be appreciated.

Thanks! Elliott

About this issue

Original URL
State: open
Created 3 years ago
Comments: 21 (1 by maintainers)

Commits related to this issue

bugfix for TimeZone issue https://github.com/sabre-io/dav/issues/1318 — committed to gador/docker-baikal-infcloud by gador 3 years ago
fix: https://github.com/sabre-io/dav/issues/1318 — committed to MrAlucardDante/baikal-docker-hass by MrAlucardDante 9 months ago
fix: https://github.com/sabre-io/dav/issues/1318 — committed to MrAlucardDante/baikal-docker-hass by MrAlucardDante 9 months ago

Most upvoted comments

Looking closer at CalDAV\Plugin.php:513, I can see the call to VObject\Reader::read($tzResult[$tzProp]), which is where the timezone is being passed to vobject’s parser. Apparently this has been discussed before https://github.com/sabre-io/Baikal/issues/695#issuecomment-394112977 and the following was suggested by @evert https://github.com/sabre-io/Baikal/issues/695#issuecomment-487299181

I have been able to get things to work if I perform the following modification to CalDAV\Plugin.php:

    public function calendarQueryReport($report)
    {
        $path = $this->server->getRequestUri();

        $needsJson = 'application/calendar+json' === $report->contentType;

        $node = $this->server->tree->getNodeForPath($this->server->getRequestUri());
        $depth = $this->server->getHTTPDepth(0);

        // The default result is an empty array
        $result = [];

        $calendarTimeZone = null;
        if ($report->expand) {
            // We're expanding, and for that we need to figure out the
            // calendar's timezone.
            $tzProp = '{'.self::NS_CALDAV.'}calendar-timezone';
            $tzResult = $this->server->getProperties($path, [$tzProp]);
            if (isset($tzResult[$tzProp])) {
                $calendarTimeZone = new DateTimeZone($tzResult[$tzProp]);
            } else {
                // Defaulting to UTC.
                $calendarTimeZone = new DateTimeZone('UTC');
            }
        }

I don’t know what kind of effect doing so will have on other systems, but this change is working for me now. I’ll do some more testing and report back if I have any further issues.

elliottjohnson on Jan 9, 2021

If you use the docker image from ckulka, I have created a docker image that’s based on his nginx variant (I don’t use the apache/httpd variant, but since it’s just the webserver, migrating should work out of the box) which includes this fix.

Here is the image name and tag : ghcr.io/mralucarddante/baikal-docker-hass:0.9.4-msmtp

And the code is on GitHub if you want to make sure I don’t do anything shady in the Dockerfile (of course I don’t) https://github.com/MrAlucardDante/baikal-docker-hass

MrAlucardDante on Dec 30, 2023

Hi, the patch https://github.com/sabre-io/dav/issues/1318#issuecomment-757380175 worked for me. the file in the docker container can be copied to a local and back after the patch: docker cp baikal:/var/www/baikal/vendor/sabre/dav/lib/CalDAV/Plugin.php .

hdwinkel on Feb 21, 2021

Is there any chance this will get fixed? I’m trying to connect my baikal calendars to Home Assistant and believe I have run into this issue

mikedrawback on Feb 14, 2023