wasm-pack: pack error on Windows 10 17746

🐛 Bug description

I just try the hello world on my computer. Project structure is

default

wasm-pack init is success default

but wasm-pack pack . is faild default

wasm-pack.log

Aug 31 10:21:31.981 INFO Running pack command...
Aug 31 10:21:31.982 INFO Path: Some(".")
Aug 31 10:21:31.982 INFO Packing up the npm package...
Aug 31 10:21:31.982 ERRO 系统找不到指定的文件。 (os error 2)

🤔 Expected Behavior

No error occurred

👟 Steps to reproduce

create new hello world project
wasm-pack init
wasm-pack pack .

🌍 Your environment

os: windows 10 x64 17746.1000 wasm-pack version: 0.4.2 rustc version: 1.30.0-nightly (02cb8f2a4 2018-08-29)

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 15 (12 by maintainers)

Commits related to this issue

Fix npm error when spawned in Windows Issue #277 - Affects running login, pack, and publish on Windows. `Command::new("npm")` launched `npm` with quotes, `"npm"`, causing a run-time error on Windows... — committed to danwilhelm/wasm-pack by danwilhelm 5 years ago
Fix npm error when spawned in Windows Issue #277 - Affects running login, pack, and publish on Windows. `Command::new("npm")` launched `npm` with quotes, `"npm"`, causing a run-time error on Windows... — committed to rustwasm/wasm-pack by danwilhelm 5 years ago
Fix npm error when spawned in Windows Issue #277 - Affects running login, pack, and publish on Windows. `Command::new("npm")` launched `npm` with quotes, `"npm"`, causing a run-time error on Windows... — committed to rustwasm/wasm-pack by danwilhelm 5 years ago

Most upvoted comments

this might help: https://github.com/rust-lang/rust/issues/42791

luotaoyeah on Nov 7, 2018

@danwilhelm thanks for the fix. I’ll test then(my locale gussing maybe almost not the cause).

csmoe on Jan 16, 2019

@danwilhelm are you on discord or IRC? feel free to reach out to me on either platfrom (i’m ag_dubs)

ashleygwilliams on Jan 11, 2019

Unfortunately, this issue affects login, pack, and publish on Windows!

I verified that the cause suggested by @luotaoyeah is indeed occurring. Command places "npm" in quotes when calling it, which causes it to fail in Windows only.

The recommended solution is to call npm using cmd /c. I am working on a PR for this and have verified the cmd /c solution works. Unfortunately, it requires some OS-specific code – but it seems unavoidable.

danwilhelm on Jan 11, 2019