rust-sdl2: "bundled" in v0.34.3 is broken on Windows

Compilation of the crate fails with the following error:

failed to run custom build command for sdl2-sys v0.34.3

Explicity requesting v0.3.42 for sdl2-sys fixes the issue:

[dependencies.sdl2-sys] version = “=0.34.2”

Everything then compiles & runs as it should.

About this issue

Original URL
State: open
Created 4 years ago
Comments: 23 (14 by maintainers)

Commits related to this issue

Comment luminance-sdl2 out from the workspace. The current build on Windows is completely broken and it’s messing the whole CI pipeline. I will re-enable it once the problem is fixed upstream. See <... — committed to hadronized/luminance-rs by hadronized 4 years ago
Disable 'bundled' and 'static-link', add README.md It turns out that the "static-link" feature flag for the `sdl2-sys` crate doesn't link `SDL2_Image` nor `SDL2_TTF`) into it, and the "bundled" featu... — committed to ebkalderon/dss-coding-assignment by ebkalderon 3 years ago
winit-24 feature flag, limit versions of some crates to fix build issues — committed to aclysma/skulpin by aclysma 3 years ago

Most upvoted comments

If it’s of any use to anyone: I never fail if I use the bundled feature together with the static-link one, for whatever reason. Is there something weird with the library binaries or something?

nylanderdev on Apr 12, 2021

The error I’m getting is that it seems like vcpkg is complaining about a casing difference between release and Release.

Vcpkg is unable to link because we cannot decide between Release and Debug libraries. Please define the property VcpkgConfiguration to be 'Release' or 'Debug' (currently 'release').

I assume from here -> https://github.com/Rust-SDL2/rust-sdl2/blob/master/sdl2-sys/build.rs#L273

therocode on Oct 2, 2020

I looked at it a little the other night and it fails here:

        for modified_file in patch_set.modified_files() {
            use std::io::{Write, BufRead};

            let file_path = sdl2_source_path.join(modified_file.path());
            let old_path = sdl2_source_path.join(format!("{}_old", modified_file.path()));
>>          fs::rename(&file_path, &old_path)
                .expect(&format!(
                    "Rename of {} to {} failed",
                    file_path.to_string_lossy(),
                    old_path.to_string_lossy()));

The filename, directory name, or volume label syntax is incorrect. (os error 123) on the fs::rename call

format!("{}_old" might should be old_{} but that doesn’t fix it. The odd thing is, I made a throw-away program that called fs::rename on the same paths and it worked fine. Really seems like it would be easy to fix but I didn’t figure out a working solution in the short amount of time I messed with it.

aclysma on Sep 19, 2020