rustup: 'Proceed with installation (default)' prompt is ambiguous
Problem
After customizing the installation, rustup shows “Proceed with installation (default)” instead of “Proceed with installation (custom)” suggesting it is going to ignore what the user has done and run a default installation instead.
Steps
- run rustup
- when presented with the three options, pick
2) Customize installation - customize the installation
- observe the label for
1)after customizing and being back in the menu
Possible Solution(s)
Change the phrasing to 1) Proceed with installation (custom) after the user has customized the installation.
Notes
This is a text bug, not a code bug.
Rustup version
Windows 10 x64:
>rustup-init --version
rustup-init 1.26.0 (5af9b9484 2023-04-05)
### Installed toolchains
```console
none, rustup hasn't installed anything yet.
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 16 (6 by maintainers)
@brettearle sure, feel free to ask questions or just submit a PR and we’ll review it!
G’day Fairly new to rust but would love to give this a shot. Can I take this on?
I think the cognitive insight here is valid and would welcome a patch to improve the situation.
Of course it’ll need code changes, but not a huge one, and rust releases are frequent, with constant changes landing. That’s literally how updates work =)
The problem with “it’s not necessary” is that it’s the wrong way to look at the problem. Can it be improved? Absolutely. Is it an easy improvement? Possibly. So mark it as enhancement, and when someone gets to it, that’s an improvement for everyone. The worst thing to suggest is “let’s not do this because we don’t need it”. No one needs improvements if things technically already work, but they sure make things better for everyone.
And if the workflow is “people have to try an option to discover it does nothing”, then that’s flat out bad behaviour, and is always worth fixing. People should never have to “just try things” in the hopes that they work, a good installer helps the user do what needs to be done.