rubocop-rspec: CreateList is not a safe cop

@pirj PR in draft √

Sounds great. Please don’t hesitate to send the PR early and asking questions, writing cops is tricky at first.

As I’ve mentioned somewhere above, this cop is far from perfection. We’ll keep it safe, and this is what matters. I can surely see a different FB cop that would advise using author: user.

Personally, especially after https://github.com/thoughtbot/factory_bot/issues/1444 pitfall, I strongly prefer n.times syntax.

What bothers me with this, is that we will kick our a lot (if not most) of true positive offences.

Indeed it is really common to do:

create(:user) do |user|
  create_list(:book, 3 author_id: user.id) # I know we can use `author: user` but its to expose my point
  # or the bad one, that now will not be an offense anymore
  3.times { create(:book, author_id: user.id) }
end

Your solution seems easier to apply. I’m ok to go with that I just want to point out that this will probably kill a lot “it happens really often in real-life use cases” true positive detections