DpadRecyclerView: Bug: DpadSpanSizeLookup's getSpanSize function is being called infinitely while fast scrolling

Hi there,

I’m using DpadRecyclerView to show a grid of items in 4 columns, and I have header views to show the items in sections. The important part is that section items are not full, there are some empty cells in each section’s last row.

The issue is when I scroll up from an item that doesn’t belong to the first column, it stops scrolling and after a while, and crashes with an ANR. I found that there is a problem with the getSpanSize function. Here is part of my logs:

11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 57
11:43:47.514 DebugTag       D  getSpanSize: 60
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 59
11:43:47.514 DebugTag       D  getSpanSize: 58
11:43:47.514 DebugTag       D  getSpanSize: 58

and here is my code:

 private fun setupRecyclerView(recycler: DpadRecyclerView) {
        recycler.adapter = adapter
        recycler.setSpanCount(SPAN_COUNT)

        recycler.setSpanSizeLookup(object : DpadSpanSizeLookup() {
            override fun getSpanSize(position: Int): Int {
                return if (position in 0 until adapter.itemCount && adapter.isSectionHeader(position)) SPAN_COUNT else 1
            }
        })

        recycler.attachListController(viewModel.listController)

        recycler.setSmoothScrollSpeedFactor(2f)
        recycler.setSmoothScrollMaxPendingMoves(1)
    }

I would appreciate it if you could help me fix this. Is there anything I can do to have it before the next library release? Thanks in advance.

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 19 (11 by maintainers)

Most upvoted comments

@tyrel-carlson

Thanks for the feedback. I will make focusOutFront and focusOutBack enabled by default in the next release.

Regarding the grid focus, I think that makes sense, I will open a new issue and solve that as well

@tyrel-carlson that’s exactly what I did in https://github.com/rubensousa/DpadRecyclerView/pull/219 I plan to release this soon