rspec-rails: undefined local variable or method `tagged_logger' during perform_enqueued_jobs
What Ruby, Rails and RSpec versions are you using?
Ruby version: 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-darwin21] Rails version: 7.0.0 RSpec 3.10
- rspec-core 3.10.1
- rspec-expectations 3.10.1
- rspec-mocks 3.10.2
- rspec-rails 5.0.2
- rspec-support 3.10.3
Observed behaviour
Inside an rspec support module, my app is calling perform_enqueued_jobs. The spec in question that is using this support module is expecting this call to raise an exception.
When I attempt to run this spec, the following is raised:
got #<NameError: undefined local variable or method `tagged_logger'
When I debug into perform_enqueued_jobs, I am taken into _assert_nothing_raised_or_warn inside activesupport-7.0.0/lib/active_support/testing/assertions.rb, When debugging the block below, it shows e as having the expected exception.
rescue Minitest::UnexpectedError => e
if tagged_logger && tagged_logger.warn?
warning = <<~MSG
#{self.class} - #{name}: #{e.error.class} raised.
If you expected this exception, use `assert_raises` as near to the code that raises as possible.
Other block based assertions (e.g. `#{assertion}`) can be used, as long as `assert_raises` is inside their block.
MSG
tagged_logger.warn warning
end
raise
end
Debugging further reveals that the if tagged_logger check above is causing the undefined error.
I reported this on Rails forum here and a member of the core team suggested the following:
“This seems to be a bug in RSpec that doesn’t implement the tagged_logger. Please report the issue in the RSpec issue tracker.”
Expected behaviour
The spec should finish and allow to raise_error to check for the expected exception. This spec is working as expected in Rails 6.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 13
- Comments: 25 (12 by maintainers)
I’m using the following crappy patch, as including the module into
RSpec::Rails::RailsExampleGroupdid not do anything.Also defined a dummy
namemethod (sigh), to resolve the subsequent issue that @jkwuc89 raises just above (which this also runs into)PRs would be accepted to solve this,
RailsExampleGroupshould conditionally (as in, if on Rails 7) include this module, and ideally we’d want a snippet testing it.I’m still seeing this issue with Ruby (3.3.5), Rails (7.1.4), rspec (3.13.0), rspec-rails (7.0.1). To me it’s pointing here:
But don’t think is has to do with FactoryBot, it’s seems is just because I have my perform_enqueued_jobs in a factory.
Any news on this cc @jkwuc89 @pirj @JonRowe
@JonRowe the problem still persists, version
6.0.1Here is a quick monkey patch using @pirj suggested solution
@pirj I just saw this error in 6.0.1, and the monkey patch above https://github.com/rspec/rspec-rails/issues/2545#issuecomment-1029539971 can fix the issue.
However, I find I missed
type: :jobin my spec. If I add it, everything works fine. I think it’s because the error is raised byRSpec::Core::ExampleGroupif I don’t addtype: :job, so the monkey patch works. When running a spec withtype: :job,RSpec::Rails::RailsExampleGroupis included, so the fix works. Does it make sense?It feels like they are checking for a tagged logger by assuming it exists, they could easily fix this by checking its defined
I don’t know, that looks to me like the factory needs to have the tagger logger included and thats out of scope for us.
@sebaherrera07 Can you please:
I’m running this code:
and am getting this error:
I got past the first “tagged logger” error by adding
include ActiveSupport::Testing::TaggedLogging, however I’m seeing this afterward and haven’t seen anything addressing it. Addingdef namedid not work for me.Because this is only for Rails example groups. But the patch you refer to does patch it for all example groups. Do you add proper metadata to your Raisl-related example groups?
I also see the same error with 6.0.1, my code looks similar
Ruby 3.2.1, rails 7.0.4
I think rspec-rails should be responsible for making sure the features of
ActiveSupport::TestCaseit uses works with RSpec, nor Rails that should check if its own API is existent.I’ll take a deeper dive into this and report what I find.