rook: Helm chart should not upgrade Storage classes and snapshot classes

Is this a bug report or feature request?

  • Bug Report

Deviation from expected behavior: The cluster helm chart attempts to upgrade storage classes when their properties change, which causes a failure such as:

StorageClass.storage.k8s.io "ceph-filesystem" is invalid: parameters: 
Forbidden: updates to parameters are forbidden.

Expected behavior: Storage classes and snapshot classes are immutable. If their properties change, they should not be updated with the helm chart upgrade.

We should be able to accomplish this with the lookup function. If the lookup of the storage class says it doesn’t exist, then we create it. Otherwise, we skip the update. Here is an example of using the lookup to see if a resource exists.

How to reproduce it (minimal and precise):

  1. Install the cluster helm chart with a storage class
  2. Change a helm property that causes and update in the storage class
  3. Upgrade the helm chart
  4. See the helm chart failure since the storage class is immutable

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 17 (7 by maintainers)

Most upvoted comments

I can take it up if it’s not urgent, Would be a great start to get my hands dirty with Helm