image-comparison: StackOverflowError when compared 2 images with a little big different area.

Hello @romankh3 I got a Exception: Exception in thread "main" java.lang.StackOverflowError at ua.comparison.image.ImageComparison.joinToRegion(ImageComparison.java:110) when compared 2 images with a little big different area. Image resolution of both are : 1920 * 931, as attached image1: baidu1 image2: baidu2

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 17 (11 by maintainers)

Commits related to this issue

#21: fixed bug with StackOverFlowError. — committed to romankh3/image-comparison by romankh3 5 years ago
#21, #38 (#40) * #21: fixed bug with StackOverFlowError. * #38: remove all test data from src/resource folder. — committed to romankh3/image-comparison by romankh3 5 years ago
Updated tests for #11 and #21. — committed to romankh3/image-comparison by romankh3 5 years ago

Most upvoted comments

I created a PR for it https://github.com/romankh3/image-comparison/pull/28 but there should be added tests (or tests should be corrected, I don’t remember). The main sense of the bug that we check every pixel around the current check point. We should check only points that will be checked after the current. now:

check | check | check 
check |   *   | check  
check | check | check

after

  -   |   -   |   -   
  -   |   *   | check  
check | check | check

pvarenik on Mar 15, 2019

Issue is still occurring. Any news?

Markaleth on Mar 15, 2019