helmfile: remove "helm diff" errors when doing apply

when doing a helmfile apply there are errors coming from the helm diff plugin and this is really confusing. I understand this is the --detailed-exitcode option of helm diff that does this but that would be nice to not have those errors displayed. I would suggest either file the output in helmfile or may be contribute in to helm diff repos to have a quiet version.

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 5
Comments: 17

Commits related to this issue

Various U/X improvements for `helmfile apply` This improves the U/X of `helmfile apply`, by allowing you to selectively apply sub-helmfiles. When you have two or more sub-helmfiles processed, typing ... — committed to roboll/helmfile by mumoshu 5 years ago
Various U/X improvements for `helmfile apply` (#586) * Various U/X improvements for `helmfile apply` This improves the U/X of `helmfile apply`, by allowing you to selectively apply sub-helmfiles. ... — committed to roboll/helmfile by mumoshu 5 years ago

Most upvoted comments

@mumoshu - ahhh! … that’s probably the reason … we’ve got:

helm version
Client: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.9.1", GitCommit:"20adb27c7c5868466912eebdf6664e7390ebe710", GitTreeState:"clean"}

I’ll see if we can try and bump to a version > 2.11.x soon, and then test again… thanks for all your help! 😃

madAndroid on May 17, 2019

Thanks for the detailed explanation! Yeah this should definitely be fixed.

–quiet sounded good, but it seems to make it impossible for us to show diff when it exists.

I’d tweak the log level for this helm diff runs probably to DEBUG in case of “successful statuses”(not necessarily 0 in this case), in othercases INFO(default) as it is today.

mumoshu on Apr 5, 2019

@mumoshu - thanks! I should be able to try it out sometime this week … will be sure to keep you posted on the results 😃

madAndroid on May 15, 2019

@madAndroid Thanks fo reporting!

That’s what --detailed-exitcode should do in the first place! So I took some time to investigate what’s happening, and found a possibly relevant bug. I’ve fixed it in #586

mumoshu on May 10, 2019