helmfile: `needs` doesn't work for upgrades.
needs doesn’t work for already deployed releases and also for selected releases using --selector.
If I make changes to my-release and kubernetes-external-secrets and then run helmfile apply I get this error:
syncing 2 groups of releases in this order: consul, elk, external-secrets, kube-system/kubernetes-external-secrets, kube2iam, redis, storage -> default/my-release
err: "default/my-release" needs "consul", but it must be one of kube-system/kubernetes-external-secrets, default/my-release
So dependecies without changes are not taken into account. For the same reason --selector doesn’t work as well.
The issue is critical, since needs is usable only for clean installation.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 1
- Comments: 19
Commits related to this issue
- fix: Fix `needs` to work for upgrades and when selectors are provided Fixes #919 — committed to roboll/helmfile by mumoshu 5 years ago
- fix: Fix `needs` to work for upgrades and when selectors are provided (#922) * fix: Fix `needs` to work for upgrades and when selectors are provided Fixes #919 * Add test framework for `helmfil... — committed to roboll/helmfile by mumoshu 5 years ago
- Port the fix for `needs` to `helmfile delete` and `destroy` This ports the fix for `helfmile apply` to `delete` and `destroy`, so that specifying `--selector` does not break those commands anymore. ... — committed to roboll/helmfile by mumoshu 5 years ago
- Port the `needs` fix for `helmfile apply` to `sync`, and make `template` DAG-aware This ports the fix for `helfmile apply` to `sync`, so that specifying `--selector` doesn't break `helmfile sync`. A... — committed to roboll/helmfile by mumoshu 5 years ago
- Port the `needs` fix for `helmfile apply` to `sync`, and make `template` DAG-aware (#940) This ports the fix for `helfmile apply` to `sync`, so that specifying `--selector` doesn't break `helmfile sy... — committed to roboll/helmfile by mumoshu 5 years ago
Hey! v0.90.6 tagged. Probably it will be released in a few minutes.
@mumoshu Hi! Since the PR with the bugfix code is already merged to master, can you please tag a new release so that the binaries with the fix will be available for download ? Thank you