roadrunner: [๐Ÿ› BUG]: marshal_payload: string field contains invalid UTF-8

No duplicates ๐Ÿฅฒ.

  • I have searched for a similar issue in our bug tracker and didnโ€™t find any solutions.

What happened?

Updating to 2024.1 breaks some http requests that worked previously.

Version (rr --version)

2024.1+ (protobuf)

How to reproduce the issue?

Send a request with some invalid data. For example, an invalid third-party cookie. We get 500 status code.

curl --request GET \
  --url http://localhost/ \
  --header 'Cookie: name=%A7 '

Relevant log output

No response

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 18 (9 by maintainers)

Most upvoted comments

Thank you, now everything works!

DTO was changed, wait for the PHP part release.

Ok, so, yeah, bytes/string is a single string type in PHP when compiled from protobuf.

Hey @GityaMan ๐Ÿ‘‹๐Ÿป Iโ€™ll sync with the our PHP team today to double check the case I wrote above. If no BC should be introduced to fix that, then sure, Iโ€™ll release a patch soon.

Yeah, I know. Currently, cookies are represented as a hashmap in our protocol. As you may see, we use strings. Strings are UTF-8 only (this is why you see that error). To support non-utf-8 strings, cookies should be represented as bytes arrays. I guess (Iโ€™m not a PHP dev) that in PHP, there is no difference between these wire proto-types (how theyโ€™re represented in PHP) and that wonโ€™t require an update from the PHP side.