rietveld: upload fails if there is no diff.exe in your path

upload runs svn diff like this:
  data = RunShell("svn diff --diff-cmd=diff", args)
It makes sense to override any GUI diffing program, but this also means 
that upload fails if you don't have a diff in your path.  However, "svn 
diff" works fine as it uses its own built-in differ.

(This is on Windows, where it's not common to have "diff" available.)

Perhaps there's some way to tell svn to use its internal diff 
implementation?  Or perhaps there's some way to test whether svn's default 
implementation has been overriden?

Original issue reported on code.google.com by evan.mar...@gmail.com on 9 Jul 2008 at 9:32

About this issue

  • Original URL
  • State: closed
  • Created 12 years ago
  • Comments: 15

Most upvoted comments