actionlint: TestLintFindProjectFromPath test fail on v1.6.25

Running go test -v ./ ./scripts/... on v1.6.25 fails with this error:

=== RUN   TestLintFindProjectFromPath
    linter_test.go:223: no error was detected though the project was found from path parameter
--- FAIL: TestLintFindProjectFromPath (0.00s)

Although it says no error was detected, but it fails, I haven’t investigated more. Full log: https://github.com/aminvakil/aur/actions/runs/5282061811/jobs/9556494234?pr=274#step:11:1968

Tests are running every night and it was fine during the previous upgrades, you can see more in github repository as well.

About this issue

Original URL
State: closed
Created a year ago
Comments: 23 (11 by maintainers)

Commits related to this issue

actionlint: Fix running unit tests This fixes https://github.com/rhysd/actionlint/issues/307 — committed to rhysd/aur-for-actionlint-bug by rhysd a year ago
actionlint: Fix running unit tests This fixes https://github.com/rhysd/actionlint/issues/307 — committed to archlinux/aur by rhysd a year ago
create fake `.git` directory to test detecting repository root (#307) instead of using actionlint's `.git` directory — committed to rhysd/actionlint by rhysd a year ago

Most upvoted comments

https://github.com/aminvakil/aur/pull/274 tests passed and merged.

You can see the result https://aur.archlinux.org/cgit/aur.git/log/?h=actionlint

aminvakil on Jun 20, 2023

I fixed the test case to work even if actionlint/.git doesn’t exist. From v1.6.26 release, you can safely remove the change in https://github.com/aminvakil/aur/pull/281.

rhysd on Jun 20, 2023

can’t it at least look for .github folder presence?

There is no guarantee that .github directory is put in root repository only. For example, .github directory may be put in somewhere else and symlinked to root of the repository. It’s better to check both .git and .github IMO.

rhysd on Jun 20, 2023

Merged, shouldn’t this get fixed here though? Why is .git presence necessary?

I’ll add fix in this repository as well. However, for releasing v1.6.25, the fix in your side would be necessary until the next version (probably v1.6.26) is released.

.git is necessary because TestLintFindProjectFromPath checks if actionlint can find repository root directory. actionlint finds repository root by looking at .git directory. Currently actionlint repository’s .git is used for the test. Git does not allow committing .git directory (git add testdata/.git is simply ignored) so it is tricky to prepare a fake .git directory for tests.

rhysd on Jun 20, 2023

Please tell me if there was any problem in running CI, …

aminvakil on Jun 19, 2023

Today I could reproduce this issue in my forked repository. I’ll investigate what is happening.

https://github.com/rhysd/aur-for-actionlint-bug/actions/runs/5312477943/jobs/9617034652

rhysd on Jun 19, 2023