app: Support notification on error

The checks API or the status API might be a good way to resolve letting people know if the settings were updated or not. I think the checks would be the better way as you can provide more information about what failed.

here is a diff where I add it https://github.com/probot/settings/compare/master...kyleroush:master With this if the settings are all updated it will add a successful check or if the update fails it can describe what failed. Right now when it is failing I am just showing the response body of what failed which is not the prettiest. Here is an example of it failing https://github.com/kyleroush/test4/runs/253938319

But doing something like this would probably involve having to request new authorization persions to the checks API for the bot

I did a similar thing for the WIP app, I use it to explain why a pull request is work in progress. You’d have to add a check in case of a forbidden error, as people are slow to accept new permissions, and you want to handle that case gracefully.

The thing isn’t what can be done or that I didn’t read the docs. The things is to somehow report such errors so user can know what and why is happening.

absolutely. sorry if my comment was unclear. i definitely think it would be valuable to find a way to report errors of all kinds rather than failing silently. i’m going to keep this issue open to track that need.

my comment was to clarify the requested test. based on the docs, i was simply pointing out that i don’t think the quoting is the problem. i think the api actually would fail in this case. regardless, it would be valuable to provide feedback about the failure.

Yes, okay, I’m not stupid.

The thing isn’t what can be done or that I didn’t read the docs. The things is to somehow report such errors so user can know what and why is happening.

Anyway, we will close that cuz you all want.

I just installed app and nothing happen. I don’t know what I need to fix in config. Notification is very important.

I think this is pretty essential. As far as I know, this app just fails silently without any way whatsoever to find out what went wrong. Especially for an app that has so much access to organisations it is essential to have good messaging to enable trust.

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

defining a schema or similar to validate against is the main work that we would need to find time to complete, but i’m open to discussing further, especially if there are ideas around tools that could help simplify.

as a quick follow up, i’ve seen that it is possible to validate yaml files against a json-schema, so i’ve opened https://github.com/probot/settings/issues/182 for looking more into that. i would be more than open to someone investigating that and helping it move forward