app: Branch protection not being applied

I can’t get this to work either. I’d love some visibility of what’s happening when it tries to apply my yaml!

You are right. It works if all top-level settings are included.

Thanks for the tip.

That’s my current one:

branches:
  - name: master
    # https://developer.github.com/v3/repos/branches/#update-branch-protection
    # Branch Protection settings. Set to null to disable
    protection:
      # Required. Require at least one approving review on a pull request, before merging. Set to null to disable.
      required_pull_request_reviews:
        # The number of approvals required. (1-6)
        required_approving_review_count: 1
        # Dismiss approved reviews automatically when a new commit is pushed.
        dismiss_stale_reviews: true
      required_status_checks: null
      restrictions: null
      enforce_admins: null

I won’t work if I set then to false like in:

branches:
  - name: master
    # https://developer.github.com/v3/repos/branches/#update-branch-protection
    # Branch Protection settings. Set to null to disable
    protection:
      # Required. Require at least one approving review on a pull request, before merging. Set to null to disable.
      required_pull_request_reviews:
        # The number of approvals required. (1-6)
        required_approving_review_count: 1
        # Dismiss approved reviews automatically when a new commit is pushed.
        dismiss_stale_reviews: true
      required_status_checks: false
      restrictions: false
      enforce_admins: false

we should probably hide these details if true, but it looks like i had to set some properties that i wasn’t trying to configure to null in order to get my config to apply.

could you try some variations of that to see if gets you working? if that does end up working, i would be interested in the combination that worked as well as those that didnt so that we can try to improve configuring these.