remix: Polyfill error after `1.17.1` upgrade

What version of Remix are you using?

1.17.1

Are all your remix dependencies & dev-dependencies using the same version?

Steps to Reproduce

Upgrade to 1.17.1
Add a require in a module

Expected Behavior

Shouldn’t trigger error

Actual Behavior

Triggers an error like this:

Uncaught TypeError: Cannot assign to read only property 'Z_BEST_COMPRESSION' of object '#<Object>'
    at node-modules-polyfills-commonjs:zlib (node-modules-polyfills-commonjs:zlib:6:25)

Rolling back to 1.17.0 makes the error go away.

About this issue

Original URL
State: closed
Created a year ago
Reactions: 5
Comments: 17 (9 by maintainers)

Most upvoted comments

@MichaelDeBoey that was already merged and is on version 1.17.1, but that’s the version that’s having issues with zlib Thar PR fixed crypto(For example I was having issues with createHash) but not zlib

omar-minka on Jun 21, 2023

This will be fixed by #6562

MichaelDeBoey on Jun 21, 2023

If you can get your project to resolve to esbuild-plugins-node-modules-polyfill@v1.1.0, can you let me know if it solves your issue?

@markdalgleish I updated to 1.18 and 1.1.0 of the polyfills package seems to be getting resolved…and the error is gone. I think we can say this issue is solved.

brandonpittman on Jun 28, 2023