refined-github: Bug: "More" dropdown always expanded

Update:

NOTE: A new version (19.8.21) has already been released, please restart your browser and wait for the plugin to update. For Chrome users, you can go to chrome://extensions/, toggle on “developer mode” on the top right corner, and click the “Update” button to immediately receive the update.

Original issue below:

Refined GitHub enabled on Chrome:

image

Disabled:

image

It just started today, and I’ve only noticed it does this when viewing a Repo (not other views afaik).

Clicking the dropdown, or anything, doesn’t hide the dropdown. Seems like it’s just stuck in this state.

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Reactions: 233
  • Comments: 28 (7 by maintainers)

Commits related to this issue

Most upvoted comments

For anyone having trouble, you can find more-dropdown in the extension’s settings. For chrome, just right click on the extension(refined github in this case) and click on options. Once there, just scroll down and you will find more-dropdown as Nightfirecat mentioned.

Not a fix for the issue, but disabling more-dropdown removes this while it is being fixed.

Hey guys please stop with the “me too” comments unless you have something to add. I think the point is made, this is broken, we have screen shots, we have browsers it’s confirmed in, it’s pretty universal.

Vote up the initial report if you want to add weight to the issue, and subscribe if you want to get updates, but (as with almost any project’s Github issues) adding new comments just to say the same thing wastes a lot of people’s time and attention. In case you missed it in comments there is a mitigation you can use for now and a permanent fix in the works.

Just a confirmation … the original report states this happens on Chrome. I’m on Firefox and seeing the same thing today. The menu is stuck open whether on old or new tabs and cannot be closed.

@busches can you pin the issue? Before a new release we need to keep people informed. If not then we should keep this issue open

Thanks for quick fix 👌

Firefox users can hit ‘Check for Updates’ in Manage Extensions too (at least, it worked for me): image

Same issue here

Chrome users: v19.8.21 includes the fix, you can force update by using developer mode and clicking on update.

Screen Shot 2019-08-21 at 12 49 07 PM

@busches Nice catch! Created a fix PR.

Can confirm brave and chrome fixed. thanks a bunch!

As a temporary solution, I created #2358 till we get a proper fix

Same on Brave

Looks like we’re on the legacy markup and they removed support for it today. We’ll need to convert it to the <details><summary> markup you can find in the other drop downs. Most likely GHE will still need the current markup though.

@IzzySoft, that seems like a bandaid solution. We’re mimicking the native GH dropdowns and shouldn’t need extra classes, assuming the native ones work without that fix. If the native ones do work and ours don’t, that’s the fix I’d want, which should be markup, not extra styling.

@busches Let’s also add the following line at the top of the issue description:

NOTE: A new version (19.8.21) has already been released, please restart your browser and wait for the plugin to update. For Chrome users, you can go to chrome://extensions/, toggle on “developer mode” on the top right corner, and click the “Update” button to immediately receive the update.