react-redux: [5.1.0-test.1] Connected components don't re render after state update

I gave a first try to the new beta and I can see some problems (unless I should make some changes).

The components that are connected to the store via connect don’t get updated (they don’t re render). While debugging I can see that the function mapStateToProps gets called correctly (and I can see the changes) after the action but the component doesn’t re-render hence it doesn’t show the new values.

I hope it could help

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 2
Comments: 52 (41 by maintainers)

Commits related to this issue

fix connected props derived props generation This commit fixes https://github.com/reduxjs/react-redux/issues/965 The essence of the problem is that getDerivedStateFromProps is called when the incomi... — committed to cellog/react-redux by cellog 6 years ago

Most upvoted comments

Hmm. Good point. Let’s see…

Oh hey, you CAN edit release notes after the fact. Okay, will do. Thanks for the notice!

markerikson on Oct 19, 2018

@cellog That’s what the pure option does currently, which is enabled by default. We act essentially as a PureComponent already.

Again, the core issue is the misuse of gDSFP. We’re literally doing the first thing the 16.4 blog post says not to do. So, the refactor would be to not do that. We should do something closer to @bvaughn’s subscription example: https://gist.github.com/bvaughn/d569177d70b50b58bff69c3c4a5353f3

timdorr on Jul 18, 2018