go-redis: v7: breaking changes you would like to see

I am planning v7 release which should support context.Context and which will be incompatible with v6 in one or another way. So if you have in mind some other incompatible changes that make sense - you are welcome to add them here.

One such change I’ve just made is changing ZAdd from ZAdd(key string, members ...Z) *IntCmd to ZAdd(key string, members ...*Z) *IntCmd. It saves 1 allocations and is detected by compiler - so why not.

About this issue

Original URL
State: open
Created 5 years ago
Reactions: 8
Comments: 19 (10 by maintainers)

Most upvoted comments

Is v7 likely to come out in the next few months? starting a new project and considering whether to start out on the beta versions or to stick with stable for now?

catkins on Nov 25, 2019

I want you to call internal.Logf with context. Because, I injected custom logger to context. Logger is mutable by HTTP request metadata. Not a static. ( e.g. logger have HTTP request resource path, logger adding log to parent log by resource path )

nanasi880 on Jun 25, 2019

I mean it’s better to have hook point on specific operation, like getConn from pool, make new connection, etc. Just like stdlib’s net/http/httptrace.

I’d like to support something like this at some point, but there is nothing backwards incompatible so this change can wait until later.

vmihailenco on Jun 18, 2019