odo: wildfly component gets broken after storage is added

Steps to reproduce

git clone https://github.com/marekjelen/katacoda-odo-backend.git
cd /katacoda-odo-backend.
odo create wildfly
odo push
odo url create

# go to `<url>/counter`
# counter works

odo storage create data --path /data --size 100M

# wait a bit
# go to `<url>/counter`
# 404 - Not Found

odo push
# go to `<url>/counter`
# counter works

Reason why component gets broken is because widlfly assemble script moves compiled files to /wildfly/standalone/deployments

Moving all war artifacts from /opt/app-root/src/target directory into /wildfly/standalone/deployments for later deployment...
'/opt/app-root/src/target/ROOT.war' -> '/wildfly/standalone/deployments/ROOT.war'
removed '/opt/app-root/src/target/ROOT.war'

Path /wildfly/standalone/deployments is not backed by persistent volume, so when deploymentConfig is modified (new mount is added) and new deployment is triggered we lose all data that were not in persistent volume.

This is wildfly specific issue. When I tested this with nodejs or php images everything was ok, as they leave and serve all data from /opt/app-root/ and we create persistent volume for this path by default.

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 23 (22 by maintainers)

Commits related to this issue

Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago
Resolves wildfly issue Fixes https://github.com/redhat-developer/odo/issues/445 — committed to surajnarwade/odo-supervisord-image by surajnarwade 6 years ago

Most upvoted comments

also this might be the issue only in case of language runtimes which generates artifacts, and we should also mention that if someone is using custom imagestream, please use this labels there

this label is not label in imagestream but container (docker) image label

kadel on Nov 2, 2018

I am pretty sure that if we go down the go binary route, we will be able to make supervisord work seamlessly with s2i in a maintainable manner (much more than the bash scripts that test for the presence directories 😛 )

geoand on Nov 2, 2018

@kadel

I can confirm that this still does not work…

github.com/redhat-developer/odo  master ✔                                                                                                                                                                                                                                                                                                                            1h20m
▶ ./odo push
Pushing changes to component: wildfly
Please wait, building component....
+ set -eo pipefail
+ '[' -f /opt/app-root/src/.s2i/bin/assemble ']'
+ '[' -f /usr/local/s2i/assemble ']'
+ /usr/libexec/s2i/assemble
cp: cannot stat '/opt/s2i/destination/src/.': No such file or directory
Found pom.xml... attempting to build with 'mvn package -Popenshift -DskipTests -B -s /opt/app-root/src/.m2/settings.xml'
Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Maven home: /usr/local/apache-maven-3.5.4
Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.181-3.b13.el7_5.x86_64/jre
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux", version: "3.10.0-862.6.3.el7.x86_64", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[INFO] 
[INFO] -------------------< eu.mjelen.katacoda.odo:backend >-------------------
[INFO] Building PersistentStorageCounterServlet 1
[INFO] --------------------------------[ war ]---------------------------------
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ backend ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /opt/app-root/src/src/main/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ backend ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ backend ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory /opt/app-root/src/src/test/resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ backend ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ backend ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- maven-war-plugin:2.3:war (default-war) @ backend ---
failed to push component: wildfly

cdrage on Oct 15, 2018