Here’s an example I was able to strip down to minimum to still produce the error:

rector.php

<?php

declare(strict_types=1);

use Rector\Core\Configuration\Option;
use Rector\Core\ValueObject\PhpVersion;
use Rector\Set\ValueObject\SetList;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
    $parameters = $containerConfigurator->parameters();
    $parameters->set(Option::PATHS, [__DIR__ . '/src', __DIR__ . '/tests']);
    $parameters->set(Option::PHP_VERSION_FEATURES, PhpVersion::PHP_74);
    $containerConfigurator->import(SetList::PHP_74);
};

ValidateTraitTest.php

<?php

declare(strict_types=1);

namespace Phlib\Beanstalk;

use PHPUnit\Framework\TestCase;

class ValidateTraitTest extends TestCase
{
    /**
     * @var ValidateTrait
     */
    protected $validate;
}

output

$ ./vendor/bin/rector process tests/ValidateTraitTest.php                                                                                                                -1-
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 [ERROR] Could not process "tests/ValidateTraitTest.php" file, due to:
         "Syntax error, unexpected '}', expecting T_VARIABLE:792". On line: 269

env

rector/rector                      0.11.40

PHP 7.4.21 (cli) (built: Jul  5 2021 03:32:42) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.21, Copyright (c), by Zend Technologies
    with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans

macOS v11.4

You run test suite on PHP 8.0 and then you somehow allow usage of rector/rector for ^7.1

Yes, looks like an oversight. PHPStan (which inspired Rector for the rector-src workflow) runs unit tests in phpstan-src on all supported PHP versions - from PHP 7.1 to 8.0.

Resolved via https://github.com/rectorphp/rector-src/pull/624

Released under https://github.com/rectorphp/rector/releases/tag/0.11.45

Yeah, I’ve just checked and subsequent executions does not result in error, so I’ve added --clear-cache to composer rector script. Can’t work on Github Actions now but maybe it’s not required for now 🙂

I’ve just tried dev-main version in reproducer and it works properly 👍

@Wirone Clear cache helped 😃

@ondrejmirtes I’m looking into it, thanks 👍 I’m surprise Rector does not do the same by default.

@TomasVotruba I am out now, when I’ll be at home I’ll check, but I run this multiple times yesterday and had that error 😉 and it’s what Docker encapsulation does - it’s not my/your/local/ci problem since it’s executed in the same environment. Try with --clear-cache since I was using docker-compose down between runs just to be sure if provided command will work.

I will try to add Github Actions later.

@TomasVotruba Use different PhpParser instances in different places. Can’t be more specific than that - I’m not familiar with Rector’s codebase.

@TomasVotruba based on @puniserv’s comment I’ve created reproducer repo. Steps:

• clone the repo
• docker-compose run php composer install && composer rector

Docker image should be built, container created and composer install && composer rector should be executed within isolated environment. Of course it should result with Syntax error, unexpected '}', expecting T_VARIABLE.

PHP 7.4.20 “rector/rector”: “0.11.40”

FamilyRelationsAnalyzer::getPossibleUnionPropertyType

$fileName: rector/vendor/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/SourceLocator/SourceStubber/…/…/…/…/…/jetbrains/phpstorm-stubs/Core/Core_c.stub

$ancestorName: ‘Countable’ $varType: FullyQualifiedObjectType $propertyTypeNode: FullyQualified

Example to replicate issue:

declare(strict_types=1);

use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
    $containerConfigurator->services()->set(\Rector\Php74\Rector\Property\TypedPropertyRector::class);
};

<?php

declare(strict_types=1);

namespace Hmm\OhNo;

use Hmm\OhNo\Some\BlaBla;
use PHPUnit\Framework\MockObject\MockObject;

use PHPUnit\Framework\TestCase;

class SomeTest extends TestCase
{
    /**
     * @var BlaBla
     */
    private $bla;
    /**
     * @var MockObject&BlaBla
     */
    private $mock;

    protected function setUp(): void
    {
        parent::setUp();
        $this->bla = new BlaBla();
        $this->mock = $this->createMock(BlaBla::class);
    }
}

<?php

declare(strict_types=1);

namespace Hmm\OhNo\Some;

class BlaBla implements \Countable
{
    public function count(): int
    {
        return 0;
    }
}

{
    "require-dev": {
        "rector/rector": "^0.11.40",
        "phpunit/phpunit": "8.5.18"
    },
    "autoload": {
        "psr-4": {
            "Hmm\\OhNo\\": "src"
        }
    }
}

I don’t know how Rector is configured but with PHPStan on PHP 7.x I always parse phpstorm-stubs with Emulative lexer set to PHP 8 so it understands PHP 8-specific syntax in the stubs.

@TomasVotruba I use PHP 7.4.21. Provided output was with --debug (actually I’ve used -vvv). Most probably tokens are not correct after applying Rector refactoring, when file is about to be saved. But IMO it should not work this way 🙂 Will be great if Rector could handle this in a way that user would know that some rector rule is not able to produce valid syntax (if that’s the case).