reactstrap: build breaks with 5.0.0-beta.2

Issue description

  • reactstrap version #5.0.0-beta.2
  • import method es
  • react version #16.2.0
  • bootstrap version #4.0.0

What is happening?

when building with gulp + browserify this happens:

/Users/matteo/dev/my-project/node_modules/react-popper/lib/react-popper.js:1
export { default as Manager } from './Manager';
^
ParseError: 'import' and 'export' may appear only with 'sourceType: module'
  • If I install 5.0.0-beta everything is fine
  • If I install 5.0.0-beta.2 the build breaks
  • If I manually install react-popper 0.8.2 and delete 0.8.1 everything is fine again

the strange thing is that react-popper was updated from 0.8.1 to 0.8.2 to “fix: build” (see https://github.com/souporserious/react-popper/commit/0d97929b038b1bba69f920772505f8d6af158f3f), while reactstrap’s commit b515e6b says “chore(build): downgrade react-popper to fix build”

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Reactions: 2
  • Comments: 20 (8 by maintainers)

Most upvoted comments

Similar issue with a Gatsby SSR starter using reactstrap - updating to 0.8.2 solved it.

The fix build was supposed to downgrade the version in the yarn lock, I didn’t notice it was bumped in the package.json… Yay two package systems! …

v0.8.2 doesn’t have this issue: https://unpkg.com/react-popper@0.8.2/lib/react-popper.js v0.8.1 does: https://unpkg.com/react-popper@0.8.1/lib/react-popper.js Since it’s complaining about export { default as Manager } from './Manager';, only the versions with that code would be an issue… right?