rxjs: takeUntil docs wrong.

EDIT: (blesh) We need to update the docs

The docs should describe the behavior when the notifier passed to takeUntil does not emit, and instead completes. (for example, Observable.empty() or Observable.timer(100).ignoreElements())

---

Original Post

takeUntil on reactivex.io states

The TakeUntil subscribes and begins mirroring the source Observable. It also monitors a second Observable that you provide. If this second Observable emits an item or sends a termination notification, the Observable returned by TakeUntil stops mirroring the source Observable and terminates.

(emphasise is mine)

Similar, the docs state:

takeUntil subscribes and begins mirroring the source Observable. It also monitors a second Observable, notifier that you provide. If the notifier emits a value or a complete notification, the output Observable stops mirroring the source Observable and completes.

(emphasise is mine)

However, in the specs:

it('should take all values when notifier is empty', function () {

I think the correct behaviour would be to terminate when the notifier terminates, however at the very least the docs should be in line with the specs.