google-signin: SignIn() appears stuck and return nothing after the app reloads for several times on Android.

happening to me as well

I’m seeing the same issue. (Again.)

At this point I guess this is just an annoyance during debugging. But I’m nervous that CodePush reloads may also trigger this problem when we try to update our bundle post-deployment.

I know that the maintainers have looked at this before and couldn’t reproduce it or track it down. But I’m wondering if there is a way to build something into the API to allow client code to flush or cancel existing requests, or something. Even if it’s ugly.

There is a fix for a race condition issue in #623. If you still get signIn() to stuck please report here.

Yes,I just did what @ganesh-pprasad did.

I haven’t come across any error after changing the source code in RNGoogleSignInModule:

    private void handleSignInTaskResult(Task<GoogleSignInAccount> result) {
        try {
            GoogleSignInAccount account = result.getResult(ApiException.class);
            WritableMap params = getUserProperties(account);
            //new AccessTokenRetrievalTask(this).execute(params);
            new AccessTokenRetrievalTask(this).executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR,params);

        } catch (ApiException e) {
            int code = e.getStatusCode();
            promiseWrapper.reject(String.valueOf(code), GoogleSignInStatusCodes.getStatusCodeString(code));
        }
    }

@jozan, @vonovak Would you consider using executeOnExecutor in the next version?

The issue still appears for me Both production and dev 1.2.1 version

We had this issue in our app, and a colleague of mine found the issue. Posting it here, before I send PR for you guys.

Our MainActivity.java looked like this (relevant parts).

public class MainActivity extends AppCompatActivity implements DefaultHardwareBackBtnHandler {
  private ReactRootView mReactRootView;
  private ReactInstanceManager mReactInstanceManager;

  @Override
  protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    // Setup react root view.
    mReactInstanceManager = getReactNativeHost().getReactInstanceManager();
    mReactRootView = new ReactRootView(this);
    mReactRootView.startReactApplication(mReactInstanceManager, getMainComponentName(), null);
    setContentView(mReactRootView);
  }

  @Override
  public void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    // Notify the facebook sdk of the activity result.
    MainApplication.getCallbackManager().onActivityResult(
      requestCode,
      resultCode,
      data
    );
  }

Then in de onActivityResult you see super being called, but that is not enough to trigger the instance manager event. We still need to call onActivityResult on the mReactInstanceManager we created.

@Override
  public void onActivityResult(int requestCode, int resultCode, Intent data) {
    ...
    // --- ADD THIS ---
    if (mReactInstanceManager != null) {
      mReactInstanceManager.onActivityResult(this, requestCode, resultCode, data);
    }
  }

Now I think we added some non-standard code to get other parts of the app working, but assuming people add Google Signin, they also add Facebook Login and overwriting the onActivityResult on their MainActivity.java file. I also did a quick Google and see some boilerplates using the ReactInstanceManager.

Hope this helps some people out. Let me know so I can add it to the Android guide with a PR