datetimepicker: TimePicker display="spinner" no longer working in RN 64 (Android)
Bug report
Hello!
Summary
Setting display to spinner on the time picker in Android renders a clock in React Native 64. It works as expected in React Native 63. I have only tested on Android.
Reproducible sample code
See this repo for a sample. Branch main
uses RN 63 and works as expected. Branch rn-64
is exactly the same code, simply upgraded by running npx react-native upgrade
https://github.com/klandell/time-spinner-bug
Steps to reproduce
Open the app on an Android device. Click show time spinner. On react native 63, it shows as a spinner. On react native 64 it shows as a clock.
Environment info
Vanilla react native app, not Expo.
System:
OS: macOS 11.1
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Memory: 564.87 MB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 15.0.1 - /var/folders/bq/rv3dbnrd4gnfymg9n66rgdc80000gn/T/yarn--1615903404422-0.9955909284122346/node
Yarn: 1.22.10 - /var/folders/bq/rv3dbnrd4gnfymg9n66rgdc80000gn/T/yarn--1615903404422-0.9955909284122346/yarn
npm: 7.0.3 - /usr/local/bin/npm
Watchman: Not Found
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.4, DriverKit 20.2, macOS 11.1, tvOS 14.3, watchOS 7.2
Android SDK:
Android NDK: 21.0.6113669
IDEs:
Android Studio: 4.1 AI-201.8743.12.41.6953283
Xcode: 12.4/12D4e - /usr/bin/xcodebuild
Languages:
Java: 11.0.9 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.1 => 17.0.1
react-native: 0.64.0 => 0.64.0
react-native-macos: Not Found
npmGlobalPackages:
*react-native*: Not Found
datetimepicker version: 3.2 iOS / Android version: Samsung Galaxy S20e, Android 10.
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 15 (10 by maintainers)
🎉 This issue has been resolved in version 3.4.1 🎉
The release is available on:
Your semantic-release bot 📦🚀
My recommendation is to do:
I’ll set up a PR