cli: Cannot find module 'react-native/cli'

Hi @thymikee, thanks for the quick response. Our React Native package.json file is in a subdirectory called app within the main repo which also has a package.json for server / web stuff. Gradle is called from app/android/gradlew.

Unfortunately I spoke to soon regarding downgrading the version, that ultimately failed too.

I saw that the getCommandOutput method no longer sets a current working directory, which was done in #852. I’m not entirely sure I understand the reasoning for this, but just as a quick hack to get our build working again, I tried to set the working directory to jsAppDir (I just applied this using patch-package):

diff --git a/node_modules/@react-native-community/cli-platform-android/native_modules.gradle b/node_modules/@react-native-community/cli-platform-android/native_modules.gradle
index 8f5dc40..06f6e6c 100644
--- a/node_modules/@react-native-community/cli-platform-android/native_modules.gradle
+++ b/node_modules/@react-native-community/cli-platform-android/native_modules.gradle
@@ -148,10 +148,10 @@ class ReactNativeModules {
    * Runs a specified command using Runtime exec() in a specified directory.
    * Throws when the command result is empty.
    */
-  String getCommandOutput(String[] command) {
+  String getCommandOutput(String[] command, File directory) {
     try {
       def output = ""
-      def cmdProcess = Runtime.getRuntime().exec(command)
+      def cmdProcess = Runtime.getRuntime().exec(command, null, directory)
       def bufferedReader = new BufferedReader(new InputStreamReader(cmdProcess.getInputStream()))
       def buff = ""
       def readBuffer = new StringBuffer()
@@ -194,10 +194,10 @@ class ReactNativeModules {
      */
     def cliResolveScript = "console.log(require('react-native/cli').bin);"
     String[] nodeCommand = ["node", "-e", cliResolveScript]
-    def cliPath = this.getCommandOutput(nodeCommand)
+    def cliPath = this.getCommandOutput(nodeCommand, new File(this.jsAppDir))
 
     String[] reactNativeConfigCommand = ["node", cliPath, "config"]
-    def reactNativeConfigOutput = this.getCommandOutput(reactNativeConfigCommand)
+    def reactNativeConfigOutput = this.getCommandOutput(reactNativeConfigCommand, new File(this.jsAppDir))
 
     def json
     try {

This seems to be working for us so far, though I’m not sure what other side effects this could have. I believe it could potentially solve #804 too, though I haven’t looked into that too deeply.

Thank you!

I solved it by upgrading my project from React Native 0.61 -> 0.62.2, because 0.62.2 uses up-to-date-enough version of the cli:

    "@react-native-community/cli": "^4.5.1",
    "@react-native-community/cli-platform-android": "^4.5.1",
    "@react-native-community/cli-platform-ios": "^4.5.0",

https://github.com/facebook/react-native/blob/v0.62.2/package.json#L89-L91

Thanks a lot for fixing the bug initially 👍

I am also facing this issue after I upgraded my react-native version from 0.60.4 to 0.61.5 and this error I am seeing on app center only.

I don’t have any config, it’s done totally their ci. i.e.

Another workaround for this issue is to put something like this in the pre-build script.

cp -a "$APPCENTER_SOURCE_DIRECTORY/mobile/" $APPCENTER_SOURCE_DIRECTORY

Of course, instead of /mobile put your RN directory path inside the repo.

So after fix #1057, who should upgrade what to which version, to make this work in appcenter.ms? Is it react-native that should be upgraded?

@fabienso Android builds have been failing in App Center since 09:30 UTC and the status page still reports Experiencing Issues. Maybe try again once this has been resolved?

Is it fixed? Or any real fix here? I am not able to build it in AppCenter. I am using yarn workspaces