react-native-cameraroll: iOS: Sort order unexpected

When attempting to request all photos, photos are returned sorted by collection, instead of being a complete list. This makes it difficult to help users pick their most recent photos taken. Example:

RNCCameraRoll.getPhotos({
  first: 20,
  assetType: 'Photos',
  groupTypes: 'All',
})

Will return the 20 latest photos as expected, in the simulator. However, on a real device this may or may not return the most recent 20 photos, as it’ll sort the Collections by “end date” which will essentially show the album that was last modified, and show all photos from that album regardless of their date.

A javascript workaround is theoretically possible but it would require to fetch all photos (e.g. first: 9999..) and then sort by timestamp, which goes against the purpose of using cursors.

After tinkering with the source, it’s clear that the issue arises from first grabbing collections, then assets. Regardless of the sortDescriptor, everything will be grouped by collection:

    PHFetchResult<PHAssetCollection *> *const assetCollectionFetchResult = [PHAssetCollection fetchAssetCollectionsWithType:collectionType subtype:collectionSubtype options:collectionFetchOptions];
    [assetCollectionFetchResult enumerateObjectsUsingBlock:^(PHAssetCollection * _Nonnull assetCollection, NSUInteger collectionIdx, BOOL * _Nonnull stopCollections) {
      // Enumerate assets within the collection
      PHFetchResult<PHAsset *> *const assetsFetchResult = [PHAsset fetchAssetsInAssetCollection:assetCollection options:assetFetchOptions];

Proposed solution: I propose that we add a condition that if groupTypes is "All", then we use fetchAssetsWithOptions instead of enumerating collections. No change required to sortDescriptor