resolvers: Unable to contribute because none of the scripts work?

Describe the bug

Thought I would have a look and attempt to contribute to the project, but can’t get the tests or the build to work.

To Reproduce

Basically just tried to follow the instructions in CONTRIBUTING.md:

  1. Made sure I had updated node installed (node@19.8.1)
  2. Installed yarn, as per their instructions (yarn@3.4.1)
  3. Made a fork of the project
  4. Cloned it locally
  5. Ran yarn to install dependencies
  6. Ran yarn test to check that things worked, and got 33 failed tests with this error:

Cannot find module ‘@hookform/resolvers’ or its corresponding type declarations.

I thought maybe I needed to run yarn build first, but running that just gives me this:

No matches found: “build:*”

So… not sure what to do now 🤷‍♂️

Expected behavior

Cloning the repo, and following the instructions in CONTRIBUTING.md shouldn’t result in any errors.

Desktop:

  • OS: Windows 10

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Comments: 20 (11 by maintainers)

Most upvoted comments

👌🏻 Just opened a PR https://github.com/react-hook-form/resolvers/pull/525

Feel free to comment, contribute 😃

Fo fancy flippy log:

<details>
    <summary>Details</summary>
    Something small enough to escape casual notice.
</details>

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

It was from a fresh clone, yes, with pnpm@7.29.3

Thank you, I got the same issue as you now. Give me some time to fix it ✌🏻