react-hook-form: issue: isValid not consistent with errors while validation

Version Number

7.39.6

Codesandbox/Expo snack

https://codesandbox.io/s/empty-morning-j0yr37?file=/src/App.tsx

Steps to reproduce

input ‘aaaa’, you can see there is an error message but the button is still enabled due to isValid is true

Expected behaviour

If there is an error message, the button should be disabled

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

Code of Conduct

I agree to follow this project’s Code of Conduct

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 4
Comments: 22 (13 by maintainers)

Commits related to this issue

Merge branch 'master' into fix-#9454 — committed to react-hook-form/react-hook-form by bluebill1049 2 years ago

Most upvoted comments

@bluebill1049 This works for me, thanks for you work!

blingblingredstar on Nov 29, 2022

@blingblingredstar let me know if you want to verify the fix before I close this issue with PR.

bluebill1049 on Nov 28, 2022

Hey, I ran into the same issue in my app. I’m using an async function for the validation. The isValid field is true but the errors field has errors.

This is a regression introduced in the last patch, i am looking for a better solution before roll it back.

bluebill1049 on Nov 28, 2022

I was about to redo all of my forms using Context Provider. Thanks, guys 💙

sorry about the context api regression…

bluebill1049 on Nov 28, 2022

This issue won’t give an immediate fix, as promise-based race conditions will need to be planned and considered carefully.

bluebill1049 on Nov 28, 2022

Something changed in 7.39.6 the errors get from formState.errors always is empty

const {formState} = useFormContext()

nghieptiki on Nov 28, 2022