react-boilerplate: Error in dll reactBoilerplateDeps

Issue Type

Description

DLL plugin cannot be build when any package is added by github url.

yarn add jamiebuilds/react-loadable#v5.4.0
# In my real case I want to replace package with its fork
# yarn add michaltk/react-loadable#props-to-loader
# But it does not matter which package I replace. It happens with every replaced package.

Building the Webpack DLL...
Hash: 49295da32e05d868bff7
Version: webpack 4.12.0
Time: 1149ms
Built at: 17.07.2018 12:11:50
                      Asset      Size                Chunks                    Chunk Names
reactBoilerplateDeps.dll.js  2.89 MiB  reactBoilerplateDeps  [emitted]  [big]  reactBoilerplateDeps
chunk {reactBoilerplateDeps} reactBoilerplateDeps.dll.js (reactBoilerplateDeps) 2.43 MiB [entry] [rendered]

ERROR in dll reactBoilerplateDeps
Module not found: Error: Can't resolve 'react-loadable' in '/tmp/react-boilerplate'
 @ dll reactBoilerplateDeps

Solution from #946 does not help. If I add the dependency to internals/config.js in the exclude array, then dll plugin will build successfully, but I will get another error during project assets compilation.

ERROR in ./app/containers/not_found/loadable.js
Module not found: Error: Can't resolve 'react-loadable' in '/tmp/react-boilerplate/app/containers/NotFound'

Steps to reproduce

git clone git@github.com:react-boilerplate/react-boilerplate.git
cd react-boilerplate
yarn add jamiebuilds/react-loadable#v5.4.0

Versions

React-Boilerplate (see package.json): 3.6.0
Node/NPM: node v9.11.1, npm 6.2.0, yarn 1.7.0

About this issue

Original URL
State: closed
Created 6 years ago
Comments: 15 (12 by maintainers)

Most upvoted comments

@julienben I’m wondering the same w/ webpack. I can take a look, I need to go back and love my abandoned webpack branch back to life anyway

gretzky on Oct 10, 2018

Just realized I misread this:

I’m seeing it now on a fresh clone. Apparently the issues have been turned off for react-loadable which leaves a bad taste in my mouth. I’m going to assume it’s an issue with this lib-- any alternatives out there? loadable-components?

Yes, indeed, the issues tab is gone from the repo and I’m also not a fan of that practice.

In addition to that, there’s a serious bug where react-loadable swallows errors thrown in the rendering of the components it loads. This is the reason for which we’re still on 5.3.1 and not the latest version 5.5.0. There doesn’t seem to have any impetus for fixing it so with that and the disappearance of the issues tab, I agree completely with a replacement or even removal if possible. Will add it to the TO-DO list for the next version.

Back to the thread we’re in though… @morr’s issue is not related to react-loadable I believe, they just used it to provide an example. As soon as I can find time, I’ll try to reproduce the error with older versions of the boilerplate. Perhaps we introduced it at some point… It could’ve taken a long time to be reported since it’s such a rare use-case.

julienben on Oct 10, 2018