auryn: Failing tests, nullable param types, package maintenance?

I’ve just setup the package to make a PR and/or a suggestion, however having run the tests, I get:

...EE...E..R..EEEE.REERE.EEE...E.EEE..EE.....................RE  63 / 120 ( 52%)
..........EEEEEE.FFFE...EEEEEEEER....E....RR....EEE...E.E       120 / 120 (100%)

That’s a lot of failures before even getting started. Is this expected? If so, my next question is, is this package actually maintained or is it largely abandoned now? I don’t particularly want to fork and become the maintainer, so I’m just deciding on how I move forward with this. It’s a very good package and would be a shame to see it abandoned.

There seem to be issues around nullable types e.g. ?SomeClass $sc. I also find the default value behaviour unexpected. I.e. if I have a SomeService(?MaybeService $mc = null), then this is always null, even if MaybeService could be autoloaded and supplied. I personally worked to the idea that this would be provided if it could be found, and if not, then it uses the default, seems natural, at least to us. So I’d propose it to work that way.

Anyway, the first thing I was going to do was fix the nullable issue. Then after that I was going to address the scenario I’ve just mentioned, however if that’s against your design, then I’ll just fork and go on from there, no problem. But before launching into fixing tests and opening PRs I first want to see if this is currently, or plans to be, abandoned, and what the appetite is for change.

Thanks.

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 19

Most upvoted comments

Cool, no worries mate.

the language is falling behind and has little to no pace with the departure of key contributors.

Somewhat comically, people are also complaining about the language changing too much…