bash-preexec: `preexec` doesn't work for function declarations

$ source .bash-preexec.sh
$ preexec() { echo "just typed $1"; }
$ date
just typed date
Wed Jun 17 16:20:15 UTC 2015
$ function foo() { echo foo; }
$ foo
just typed foo
foo
$ (date)
Wed Jun 24 02:42:48 UTC 2015

About this issue

Original URL
State: open
Created 9 years ago
Comments: 34 (29 by maintainers)

Commits related to this issue

Remove ignorespace from $HISTCONTROL - Brought up in issue #6 — committed to rcaloras/bash-preexec by rcaloras 9 years ago
Follow up commit for issue #6 -Replace ignoreboth with simpley ignoredups — committed to rcaloras/bash-preexec by rcaloras 9 years ago
Invoke preexec function for subshells and funtions #6 - Watches for history changes to properly invoke preexec function. Handles duplicates and shell startup edge cases. - Still a bit of a hack si... — committed to rcaloras/bash-preexec by rcaloras 9 years ago
Got subshells working. - Addresses part of #6 - Still doesn't support functions. - Also expose the correct exit code to preexec. — committed to rcaloras/bash-preexec by rcaloras 8 years ago
Honor HISTCONTROL ignorespace and ignoreboth In 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and in 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow up comm... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth In 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and in 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow up comm... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth In 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and in 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow up comm... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth In 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and in 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow up comm... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to gaelicWizard/bash-preexec by gaelicWizard 3 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago
Honor HISTCONTROL ignorespace and ignoreboth After 3458480385f81124a9fd9a38ff384e43dd815b1c Remove ignorespace from $HISTCONTROL and after 7e55ac15fee86cdf8e08e966d8b8c9dd2bf7ad03 Follow u... — committed to ilya-bobyr/bash-preexec by ilya-bobyr 5 years ago

Most upvoted comments

bash-preexec shouldn’t change that aspect of your HISTCONTROL. It will alter it to not ignore whitespace. Ignoredups or ignoreboth were probably set by something else, but if I’m mistaken please let me know 😃

rcaloras on Aug 17, 2015