node-argon2: Build fails in argon2_node.cpp on Debian with gcc/cpp 4.9
Steps to reproduce
- npm install argon2
Expected behaviour
No compilation error, works fine with 0.19.3
Actual behaviour
> argon2@0.20.1 install /var/content/nodejs/lapv3dev/node_modules/argon2
> node-gyp rebuild
make: Entering directory '/var/content/nodejs/lapv3dev/node_modules/argon2/build'
CC(target) Release/obj.target/libargon2/argon2/src/opt.o
CC(target) Release/obj.target/libargon2/argon2/src/argon2.o
CC(target) Release/obj.target/libargon2/argon2/src/core.o
CC(target) Release/obj.target/libargon2/argon2/src/blake2/blake2b.o
CC(target) Release/obj.target/libargon2/argon2/src/thread.o
CC(target) Release/obj.target/libargon2/argon2/src/encoding.o
AR(target) Release/obj.target/argon2.a
COPY Release/argon2.a
CXX(target) Release/obj.target/argon2/src/argon2_node.o
../src/argon2_node.cpp: In constructor ‘{anonymous}::HashWorker::HashWorker(const Napi::Function&, std::string&&, std::string&&, {anonymous}::Options&&)’:
../src/argon2_node.cpp:78:35: error: cannot convert ‘std::remove_reference<{anonymous}::Options&>::type {aka {anonymous}::Options}’ to ‘uint32_t {aka unsigned int}’ in initialization
options{std::move(options)}
^
../src/argon2_node.cpp:78:35: warning: missing initializer for member ‘{anonymous}::Options::time_cost’ [-Wmissing-field-initializers]
../src/argon2_node.cpp:78:35: warning: missing initializer for member ‘{anonymous}::Options::memory_cost’ [-Wmissing-field-initializers]
../src/argon2_node.cpp:78:35: warning: missing initializer for member ‘{anonymous}::Options::parallelism’ [-Wmissing-field-initializers]
../src/argon2_node.cpp:78:35: warning: missing initializer for member ‘{anonymous}::Options::version’ [-Wmissing-field-initializers]
../src/argon2_node.cpp:78:35: warning: missing initializer for member ‘{anonymous}::Options::type’ [-Wmissing-field-initializers]
argon2.target.mk:110: recipe for target 'Release/obj.target/argon2/src/argon2_node.o' failed
make: *** [Release/obj.target/argon2/src/argon2_node.o] Error 1
make: Leaving directory '/var/content/nodejs/lapv3dev/node_modules/argon2/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:189:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Linux 3.16.0-7-amd64
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /var/content/nodejs/lapv3dev/node_modules/argon2
gyp ERR! node -v v10.15.1
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! argon2@0.20.1 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! Failed at the argon2@0.20.1 install script.
Environment
Operating system: Debian 8.11
Node version: node 10.15.1 + npm 6.7.0 + node-gyp 3.8.0
Compiler version: gcc/cpp 4.9
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 3
- Comments: 15 (8 by maintainers)
Yes, and publish v0.21, doing that now…