uuid: [4.1.0] UuidV1::fromString(...) is not instance of UuidV1 anymore - breaking change?

Describe the bug

Using the following code I was able to check whether $uuidString is a v1 UUID,

$validV1 = UuidV1::fromString('08a527be-8e7a-11e9-bc42-526af7764f64') instanceof UuidV1;

Now it returns false, so:

maybe it wasn’t the best option to check it - how would you do it in 4.1?
regardless whether it’s best or not solution - it looks like a breaking change which shouldn’t happen in minor release

About this issue

Original URL
State: open
Created 4 years ago
Comments: 19 (13 by maintainers)

Commits related to this issue

Update DbalProducer.php from this thread https://github.com/ramsey/uuid/issues/327 ramsey/uuid 4.1 introduced LazyUuidFromString object which is used over the original Uuid object this causes con... — committed to RivieraTravel/enqueue-dev by KrisHarris 3 months ago

Most upvoted comments

Related to OP’s issue, I’d like to point out that the page for upgrading version 3 to 4 claims that Uuid::fromString returns one of the more specific types, which it doesn’t. This was what I was relying on and why I chose the same approach as OP - which ofc now backfired. Might wanna add a correction to that page if this is gonna stay this way, before somebody else stumbles over this too.

marartner on Aug 31, 2020

Should we change to Ramsey\Uuid\UuidInterface?

Yup, also there, it is documented as UuidInterface:

Ocramius on Aug 10, 2020

@ramsey yeah, I think there needs to be a bit of a harder split between the userland API (UuidInterface consumers) and advanced users (people that introspect the UUIDs post-instantiation)

Ocramius on Jul 28, 2020

Indeed, annoying: FieldsInterface seems to be completely useless.

https://github.com/ramsey/uuid/blob/69b3eb8824546bf2c06211fcf2ef630effa5ec49/src/Fields/FieldsInterface.php#L26-L32

I think what you posted above makes sense, even if it is indeed a very ugly API:

$x = new \Ramsey\Uuid\Rfc4122\Fields(Uuid::fromString('38e39072-3c2f-4f3a-a8ab-2f6be1ea3136')->getBytes());
print $x->getVersion();

Ocramius on Jul 28, 2020