ramda: on.js is missing from es/ and src/ directories and R.on is not documented

on.js is missing from es/ and src/ directories in the npm package and thus R.on is not included in the jsdoc-generated documentation.

Applying my usual method publishing a module to npm by running npm publish --dry-run or npm pack reveals that on.js gets included in the tgz file as it should. It is however missing from the package downloaded via npm install ramda. I cannot imagine where the file gets lost 🤔 How do you publish to npm?

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 18 (18 by maintainers)

Most upvoted comments

I have several Ramda chores hanging over me. I will try to get to them this weekend, and that includes republishing the docs.

CrossEye on Jan 22, 2021

@CrossEye republishing the docs might not be enough for every case.

Because e.g. on.js is missing from es/ and src/ directories in the published npm package, without a Ramda release the situation may occur, that a documentation mentioning R.on will not reflect the reality of the published npm package.

semmel on Jan 22, 2021

Yeah npm install triggers npm prepare (which is essentially npm run build) in local git repo.

This does not match my mental model at all (which explains my confusion). I see installing dependencies for local development and updating generated files for inclusion in a release tarball as completely unrelated actions.

davidchambers on Jul 30, 2020

https://github.com/ramda/ramda/releases/tag/v0.27.1

davidchambers on Jul 30, 2020

@davidchambers: If you have time to do that, I would definitely appreciate it.

CrossEye on Jul 30, 2020

@davidchambers

you need not switch to a recent Bash version permanently in order to run one command.

Good to know, I thought it’d replace the Bash shipped with macOS. Booting Ubuntu VM was however easier for me.

semmel on Jul 29, 2020

@semmel, you need not switch to a recent Bash version permanently in order to run one command. 😜

v0.27.0 was not released correctly: "version" is still "0.26.1". Would you like me to rerelease v0.27.0 as v0.27.1?

davidchambers on Jul 29, 2020

I have no clue what’s happening here. This is really odd. I’m quite busy trying to get ready for vacation. So I hope someone else has time to investigate this oddity. But if no one does, I will try to get to it before I leave this weekend.

The publish process starts with the Makefile, running make release-minor.

CrossEye on Jul 28, 2020