quarkus: @RouteFilter stopped working with WebSocket requests Quarkus 3.2.0.Final
Describe the bug
We were migrating from 2.16.7 to 3.2.0.Final
And we have WebSocket interceptor implemented with @RouteFilter
It looks like this:
@RouteFilter
void authFilter(RoutingContext rc) {
/// logic to search for websocket header etc
}
We use it to intercept GQL Subscriptions and its initial websocket request. After migration to 3.2.0.Final it stopped intercepting WebSocket for some reason.
Expected behavior
Intercept all requests as it was in 2.16.7
Actual behavior
Not intercepting websocket initial request
How to Reproduce?
No response
Output of uname -a or ver
No response
Output of java -version
17
GraalVM version (if different from Java)
No response
Quarkus version or git rev
3.2.0.Final
Build tool (ie. output of mvnw --version or gradlew --version)
gradle 8.1.1
Additional information
No response
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 19 (13 by maintainers)
Commits related to this issue
- SmallRyeGraphQLOverWebSocketHandler: use order value > Integer.MIN_VALUE - so that it's possible to register a route/filter that is executed before this handler - fixes #34908 — committed to mkouba/quarkus by mkouba a year ago
- SmallRyeGraphQLOverWebSocketHandler: use order value > Integer.MIN_VALUE - so that it's possible to register a route/filter that is executed before this handler - fixes #34908 — committed to mkouba/quarkus by mkouba a year ago
- SmallRyeGraphQLOverWebSocketHandler: use order value > Integer.MIN_VALUE - so that it's possible to register a route/filter that is executed before this handler - fixes #34908 (cherry picked from co... — committed to gsmet/quarkus by mkouba a year ago
- Update all non-major dependencies (mulk/mulkcms2!32) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [flow-bin](https://github.com/flowtype/flow-bin)... — committed to benkard/mulkcms2 by deleted user 10 months ago
- chore(deps): update all non-major dependencies to v3.3.0 (mulk/quarkus-googlecloud-jsonlogging!17) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [i... — committed to benkard/quarkus-googlecloud-jsonlogging by deleted user 10 months ago
@mkouba @phillip-kruger Thanks a lot for the help
@AlekseyMay So once the https://github.com/quarkusio/quarkus/pull/35188 is merged you can use
@RouteFilter(10_001)(or any value >10000).I can send a PR shortly. I’m not aware of any “internal ranges” but using a fixed value such as
-1000should be enough.This doesn’t look dependent on GraphQL, nor am I aware of any changes in this area. Perhaps a reproducer project would help?