quarkus: Regression with ForwardedParser setting an empty host header

Describe the bug

Keycloak has failing tests in https://github.com/keycloak/keycloak/pull/24639 with the upgrade to quarkus 3.2.8. The ForwardedParser is setting an empty host header eventually results in uris being returned to the client without a host.

Expected behavior

location uris should be fully formed.

Actual behavior

Location uris are missing the host “https:/auth/admin…”

The likely cause is this change https://github.com/quarkusio/quarkus/commit/d41c78bf553406c6026d28ff2795f096b9da184d#diff-26b0d509bb91cfaf3c4160496ea25fc584e85d4e2cc1b708eb72ea3b25b74c4dR124 - if there is no host header it will proceed to set an explicit empty value.

How to Reproduce?

See the pr https://github.com/keycloak/keycloak/pull/24639

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.2.8

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

About this issue

  • Original URL
  • State: closed
  • Created 8 months ago
  • Comments: 25 (18 by maintainers)

Most upvoted comments

It got fixed in Vertx. We would need to bump vertx to get the fix in.

It is not something we can fix in Quarkus only.