quarkus: No hot reload on bad configuration wich block the quarkus startup and when http.port is overridden
Describe the bug If you configure a bad value that block the first application start, there is no way to have hot reload.
If you start on a good value, but after plug a bbad config, the hot reload is ok. A configuration change will trigger the hot reload as wanted.
Expected behavior The hot reload is trigger if you change the configuration file, or a code change, even it never could be started correctly.
Actual behavior The hot reload is broken if the app never could be started a first time.
To Reproduce Steps to reproduce the behavior:
- configure a bad jdbc url on hibernate (or flyway)
- start the app
- change to good value (it won’t reload)
Environment (please complete the following information):
- Output of
uname -aorver: Darwin 18.5.0 Darwin Kernel Version 18.5.0 - Output of
java -version: openjdk version “13” 2019-09-17 - GraalVM version (if different from Java):
- Quarkus version or git rev: 0.25.0
Additional context (Add any other context about the problem here.) @cescoffier the issue that we discuss after the quarkus workshop
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 24 (24 by maintainers)
Commits related to this issue
- If start fails make sure to shutdown server It's possible start can fail after the server has started in dev mode. We need to make sure it is shut down to recover properly. Possible fix for #4815 — committed to stuartwdouglas/quarkus by stuartwdouglas 5 years ago
- After failed start make sure to read the HTTP config with the correct TCCL Fixes #4815 — committed to stuartwdouglas/quarkus by stuartwdouglas 5 years ago
- If start fails make sure to shutdown server It's possible start can fail after the server has started in dev mode. We need to make sure it is shut down to recover properly. Possible fix for #4815 — committed to mmusgrov/quarkus by stuartwdouglas 5 years ago
- After failed start make sure to read the HTTP config with the correct TCCL Fixes #4815 — committed to mmusgrov/quarkus by stuartwdouglas 5 years ago
@stuartwdouglas I got to the bottom of the error.
The problem is that when Quarkus DEv starts in error, it does not honor the
quarkus.http.portproperty and falls back to 8080. I could confirm by starting a project in failure, then fixing it, then hitting localhost:8080 with success.I also notice that after quarkus:dev starts in success, a change of
quarkus.http.portis not honored either. I don’t know if that one is related.