maxurl: Gallery buttons cannot display icons normally
Gallery buttons on the left and right sides cannot display icons normally. The box symbol means that the icon is not loaded normally, right?

About this issue
- Original URL
- State: open
- Created 4 years ago
- Reactions: 2
- Comments: 16 (7 by maintainers)
Commits related to this issue
- Check for safe glyphs (#347) — committed to qsniyg/maxurl by qsniyg 4 years ago
- Add option to use safe glyphs (#347) — committed to qsniyg/maxurl by qsniyg 4 years ago
- Don't use unicode in strings directly (#347) — committed to qsniyg/maxurl by qsniyg 4 years ago
- Add note that Noto Sans Symbols2 contains the proper glyphs Related to #347 — committed to qsniyg/maxurl by qsniyg 4 years ago
- Add (currently awful) support for images in ui css (#347) — committed to qsniyg/maxurl by qsniyg 4 years ago
Personally I was actually about to go for option 2, just because it allows for very easy overriding through the button CSS styles option (e.g.
-imu-image: "data:image/svg+xml,..."), allowing people to override the image to be whatever they want it to be. Of course I don’t expect most users to do this, but it might be useful for themes and the likes (which is already possible by importing custom settings, with+at the beginning to only override the specified settings).For seeing what the code is doing, you’re right that an svg tag is easier, but I that data urls aren’t necessarily too hard either. They’re either url encoded (which can be decoded online or through
decodeURIComponent("...")in the browser console), or base64 (again, either online orbtoa("...")). Or you can also just paste the url in the browser, then save the result (or save it from the network tab in devtools). For editing, once it’s saved, it should be just as easy because it’s the same data. The advantage the data url has though, is that you can then use the css styles option in order to change the image for future popups.If you disagree though, please let me know, these are just my thoughts on this. I think for the moment I’ll go for the data urls just because they’re also much easier to implement, but I have no problem adding an option or something if there is a use case for the other way too.
I had installed noto fonts from my package manager, and I had assumed it would include all fonts for everyone else, my bad! After looking at gucharmap (a program that lets you find which font is used for which character), turns out that it’s in Noto Sans Symbols2.
Good idea about the svg thing though, I should definitely replace it with that. Been thinking of doing that for a while, but never really got around to it for some reason haha. I’ll also add an option to allow it to be modified through the css styles.